[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 13: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 13: Code-Review+2 Looks good -- To view, visit

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#13). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#12). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 11: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 11: Sorry for the churn, I finally got to a version

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-19 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#11). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 10: Code-Review+2 (1 comment)

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 10: I'm going to do a full docker build with the

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 9: (3 comments)

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#10). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 9: Code-Review+2 (3 comments) Couple nits, but

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 8: (2 comments) I had to make a couple of other

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#9). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-18 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#8). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 7: (2 comments) Overall, this makes sense to me.

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-09-13 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Hector Acosta, Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#7). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-03-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 6: This is still relevant if someone has patience

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2019-03-18 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#6). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2018-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 5: Verified+1 Fixed the issue, confirmed that it

[native-toolchain-CR] IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2018-06-26 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6521 to look at the new patch set (#5). Change subject: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so