[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-08 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#4). Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. IMPALA-4631: don't use floating point operations for time unit conversions This was

[Impala-ASF-CR] Bump Kudu server version to latest master (a70c905006)

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Bump Kudu server version to latest master (a70c905006) .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 11: > Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/100/ It's a little

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/100/ -- To

[Impala-ASF-CR] Bump Kudu server version to latest master (a70c905006)

2016-12-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu server version to latest master (a70c905006) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5427 To unsubscribe,

[Impala-ASF-CR] Bump Kudu server version to latest master (a70c905006)

2016-12-08 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5427 to look at the new patch set (#2). Change subject: Bump Kudu server version to latest master (a70c905006) ..

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5412 To

[Impala-ASF-CR] IMPALA-4630: remove debug webpage easter egg

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4630: remove debug webpage easter egg .. Patch Set 3: Dan mentioned to me that he was also fine with removing it btw -- To view, visit

[Impala-ASF-CR] IMPALA-4630: remove debug webpage easter egg

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4630: remove debug webpage easter egg .. Patch Set 3: Code-Review+2 Done. -- To view, visit http://gerrit.cloudera.org:8080/5429 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. Patch Set 2: I'd like it removed, but I'm fine if we do that as a follow-on patch. -- To

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. IMPALA-4609: prefix thread counters in fragment profile This adds a prefix to the

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5392 To

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4982

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5418 To

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. Patch Set 2: I'm going to start the merge for this - does anyone feel strongly about

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. IMPALA-4608: Fix fragment completion times for INSERTs Fix a bug where completion

[Impala-ASF-CR](asf-site) Change git links from GitHub to the official Apache repo.

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Change git links from GitHub to the official Apache repo. .. Patch Set 1: I think that sounds good, it seems we should be making it as easy as possible for

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-08 Thread Marcel Kornacker (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4418 to look at the new patch set (#11). Change subject: IMPALA-4014: Introduce query-wide execution state. ..

[Impala-ASF-CR](asf-site) Change git links from GitHub to the official Apache repo.

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Change git links from GitHub to the official Apache repo. .. Patch Set 1: My main gripe with the apache git web UI is that it's really hard to find a URL to

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 10: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/5390 To

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-08 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#3). Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. IMPALA-4631: don't use floating point operations for time unit conversions This was

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-08 Thread Lars Volker (Code Review)
Hello Internal Jenkins, Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5390 to look at the new patch set (#10). Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 9: Fixed an issue in the request forwarding code. Will rebase again. -- To view, visit

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-08 Thread Lars Volker (Code Review)
Hello Internal Jenkins, Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5390 to look at the new patch set (#9). Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

[Impala-ASF-CR] Bump Kudu server version to latest master (a70c905006)

2016-12-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu server version to latest master (a70c905006) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5427 To unsubscribe,

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. Patch Set 2: We should consider Henry's comment in the Jira to remove it completely, since it

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5429 To

[Impala-ASF-CR](asf-site) Change git links from GitHub to the official Apache repo.

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5433 Change subject: Change git links from GitHub to the official Apache repo. .. Change git links from GitHub to the official Apache repo. In

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 2: can you rebase and resubmit? -- To view, visit

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 5: Code-Review+2 rebase carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/96/ --

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. IMPALA-4630: make debug webpage easter egg look less suspicious Remove the base64-encoding and

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 6: I'll give that a try - thanks for the tip. -- To view, visit

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 6: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe,

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 5: > I'm holding off on merging this until builds stabilise a little > more, since it's not a high

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 5: I'm holding off on merging this until builds stabilise a little more, since it's not a high

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/94/ --

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 4: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5392 To

[Impala-ASF-CR] IMPALA-4630: make debug webpage easter egg look less suspicious

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5429 Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious .. IMPALA-4630: make debug webpage easter egg look less

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/93/ -- To

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 5: Code-Review+2 Rebase past IMPALA-4628 fix -- To view, visit

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 7: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4628: Disable broken kudu test to unblock GVOs

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4628: Disable broken kudu test to unblock GVOs .. Patch Set 2: Merging directly yo unblock GVOs. Changes were tested locally. -- To view, visit

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-08 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4982 to look at the new patch set (#7). Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

[Impala-ASF-CR] IMPALA-4628: Disable broken kudu test to unblock GVOs

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4628: Disable broken kudu test to unblock GVOs .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5428 To

[Impala-ASF-CR] IMPALA-4628: Disable broken kudu test to unblock GVOs

2016-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4628: Disable broken kudu test to unblock GVOs .. Patch Set 1: (1 comment) Thanks for the review, please see PS2.

[Impala-ASF-CR] IMPALA-4628: Disable broken kudu test to unblock GVOs

2016-12-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4628: Disable broken kudu test to unblock GVOs .. IMPALA-4628: Disable broken kudu test to unblock GVOs Change-Id: I30d45acb26eb3e709a1994a89e8444ca9530d8cc

[Impala-ASF-CR] IMPALA-4628: Disable broken kudu test to unblock GVOs

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4628: Disable broken kudu test to unblock GVOs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5428/1/tests/query_test/test_kudu.py File

[Impala-ASF-CR] Bump Kudu server version to latest master (a70c905006)

2016-12-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5427 Change subject: Bump Kudu server version to latest master (a70c905006) .. Bump Kudu server version to latest master (a70c905006)

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 4: Code-Review+2 (1 comment) Rebase, carry +2

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/92/ -- To

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5418 to look at the new patch set (#3). Change subject: IMPALA-4608: Fix fragment completion times for INSERTs ..

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2016-12-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5392 To

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe,

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/91/ --

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > One option we should consider is replacing this test with a small > run of our "regular" stress

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: One option we should consider is replacing this test with a small run of our "regular" stress test

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 4: Code-Review+2 rebase carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/90/ --

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 3: Code-Review+2 Thanks, Jim! -- To view, visit http://gerrit.cloudera.org:8080/5412 To

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-12-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has abandoned this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4914 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4418 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 3: Code-Review+1 Carry Tim's +1 -- To view, visit http://gerrit.cloudera.org:8080/5412 To

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5412/2/testdata/cluster/admin File

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5412 to look at the new patch set (#3). Change subject: IMPALA-4588: Enable starting the minicluster when offline ..

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5412/1/testdata/cluster/admin File

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-4588: Enable starting the minicluster when offline .. IMPALA-4588: Enable starting the minicluster when offline IMPALA-4553 made ntp-wait succeed before kudu

[Impala-ASF-CR] IMPALA-4588: Enable starting the minicluster when offline

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4588: Enable starting the minicluster when offline .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5412/1/testdata/cluster/admin File

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > I'm ok with removing these tests if someone can explain to me what > exactly is happening so we

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. IMPALA-4608: Fix fragment completion times for INSERTs Fix a bug where completion times weren't

[Impala-ASF-CR] IMPALA-4608: Fix fragment completion times for INSERTs

2016-12-08 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5418 Change subject: IMPALA-4608: Fix fragment completion times for INSERTs .. IMPALA-4608: Fix fragment completion times for INSERTs Fix a

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 10: > Looks good. I can take a final look after you do the thread detach > fix. Done. --

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#10). Change subject: IMPALA-4014: Introduce query-wide execution state. .. IMPALA-4014: Introduce query-wide execution state. This introduces a global structure to coordinate

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 6: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-08 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4982 to look at the new patch set (#6). Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates.