[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. IMPALA-3224: De-Cloudera non-docs JIRA URLs John Russell is planning to fix the URLS in docs in a

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#7). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6406/5/fe/src/main/j

Re: [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-06 Thread Dimitris Tsirogiannis
For consistency, I believe we should at least allow an empty SORT BY() clause in the CREATE TABLE statement, but I'll defer the decision to Alex or Marcel. Dimitris On Sat, May 6, 2017 at 8:16 AM, Lars Volker (Code Review) < ger...@cloudera.org> wrote: > Lars Volker has posted comments on this c

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: call to strncmp with nullptr

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-5031: remove undefined behavior: call to strncmp with nullptr .. Abandoned Done in another commit -- To view, visit http://gerrit.cloudera.org:8080/6767 To unsubscr

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/539/ -- To view, visi

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6768 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. IMPALA-5273: Replace StringCompare with glibc memcmp glibc's memcmp, which dispatches dy

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 5: Code-Review+2 Thank you for iterating over this. I had another look and it looks good to me. -- To vi

[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 5: Lars, any more thoughts? -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 10: (20 comments) http://gerrit.cloudera.org:8080/#/c/6535/10/be/src/runtime/coordinator.cc File be/src/runti

[Impala-ASF-CR] IMPALA-5167: Use a single Kudu client across the BE

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Use a single Kudu client across the BE .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6792/1/be/src/exprs/kudu-partition-expr.

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6406 To un

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/6406/5/fe/src/main/java/

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 4: (18 comments) looking good. http://gerrit.cloudera.org:8080/#/c/6478/4/be/src/exec/hdfs-scan-node-base

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 3: Code-Review+2 Forgot to carry +2 -- To view, visit http://gerrit.cloudera.org:8080/6768 To uns

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/538/ -- To v

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6526/6/be/src/exec/kudu-scanne

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6563/

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 20: > There is still one thing that is not clear to me. Why is it allowed > to do an ALTER TABLE with an empty SO