[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5768: Better developer documentation .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In the text scanner, we were writing the

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7639 Change subject: MPALA-5776: Write partial tuple to the correct mempool .. MPALA-5776: Write partial tuple to the correct mempool In

[Impala-ASF-CR] IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

2017-08-09 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7631 Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled .. IMPALA-4737: Prevent SIGUSR1 from

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 1: (3 comments) Overall I think this looks good - obviously it needs some tests but that's

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: Ping? -- To view, visit http://gerrit.cloudera.org:8080/7581 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5768: Better developer documentation .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1027/ -- To view, visit

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5768: Better developer documentation .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7350 To unsubscribe, visit

[Impala-ASF-CR] PREVIEW: IMPALA-3208: max row size option

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-3208: max_row_size option .. Patch Set 6: This is ready for review except for the missing end-to-end tests. -- To view, visit

[Impala-ASF-CR] PREVIEW: IMPALA-3208: max row size option

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: PREVIEW: IMPALA-3208: max_row_size option .. PREVIEW: IMPALA-3208: max_row_size option This is a preview because it is missing tests. I have manually tested it

[Impala-ASF-CR] PREVIEW: IMPALA-3208: max row size option

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: PREVIEW: IMPALA-3208: max_row_size option .. PREVIEW: IMPALA-3208: max_row_size option This is a preview because it is missing tests. I have manually tested it

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4833: Compute precise per-host reservation size .. Patch Set 1: TODO: * more specific test case(s), validate new profile field for per-host min

[Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size

2017-08-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7630 Change subject: IMPALA-4833: Compute precise per-host reservation size .. IMPALA-4833: Compute precise per-host reservation size

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. IMPALA-5744: Add 'use_krpc' flag and create DataStream interface This patch

[Impala-ASF-CR] Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7626 To unsubscribe,

[Impala-ASF-CR] Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l .. Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l Change-Id:

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7624 To

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests If we ask OpenSSL to

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 7: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7408 To unsubscribe,

[Impala-ASF-CR] Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l

2017-08-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7626 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 13: Code-Review+2 More clang-tidy fixes. Rebase, carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-09 Thread Sailesh Mukil (Code Review)
Hello Impala Public Jenkins, Henry Robinson, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7542 to look at the new patch set (#13). Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface

[Impala-ASF-CR] Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1025/ -- To

[Impala-ASF-CR] Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l

2017-08-09 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7626 to look at the new patch set (#2). Change subject: Bump Kudu version to 943b1ae, and OpenSSL to 1.0.2l

[Impala-ASF-CR] Bump Kudu version to 943b1ae

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 943b1ae .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1024/ -- To view, visit

[Impala-ASF-CR] Bump Kudu version to 943b1ae

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 943b1ae .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1024/ -- To view, visit

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. Patch Set 1: I also tried this on a machine with OpenSSL 1.0.0. -- To view, visit

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1023/ --

[Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary

2017-08-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5708: Test failure with invalid exec summary .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7627/1/tests/beeswax/impala_beeswax.py

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7624 To

[Impala-ASF-CR] IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location.

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location.

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location. .. Patch Set 1: (12

[Impala-ASF-CR] IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location.

2017-08-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location. .. Patch Set 1: (15

[Impala-ASF-CR] Bump Kudu version to 943b1ae

2017-08-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 943b1ae .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7626 To unsubscribe, visit

[Impala-ASF-CR] Bump Kudu version to 943b1ae

2017-08-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7626 Change subject: Bump Kudu version to 943b1ae .. Bump Kudu version to 943b1ae Change-Id: I43a510c07b877cb18c3170a034cf9322baef16c0 ---

[Impala-ASF-CR] IMPALA-5778: clarify --read size option.

2017-08-09 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. Change subject: IMPALA-5778: clarify --read_size option. .. Patch Set 1: Code-Review+1 Looks good. -- To view, visit http://gerrit.cloudera.org:8080/7623 To unsubscribe,

[Impala-ASF-CR] IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location.

2017-08-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new change for review. http://gerrit.cloudera.org:8080/7625 Change subject: IMPALA-5412 Scan returns wrong partition-column values when scanning multiple partitions pointing to the same filesystem location.