[Impala-ASF-CR] IMPALA-5990: Part 1: JNI-based LZ4 de/compression

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. ( http://gerrit.cloudera.org:8080/8150 ) Change subject: IMPALA-5990: Part 1: JNI-based LZ4 de/compression .. Abandoned Will rework to simplify. -- To view, visit

[Impala-ASF-CR] IMPALA-5990: Part 1: JNI-based LZ4 de/compression

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8150 ) Change subject: IMPALA-5990: Part 1: JNI-based LZ4 de/compression .. Patch Set 1: I had looked at that library but concluded we would not

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 6: > > I totally agree about doing anything fancy as a

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-27 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 9: Pre-review-test run of EE tests

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 6: > I totally agree about doing anything fancy as a

[Impala-ASF-CR] Move tests related to the old join node.

2017-09-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8153 ) Change subject: Move tests related to the old join node. .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5870: Improve runtime profile for partial sort

2017-09-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8123 ) Change subject: IMPALA-5870: Improve runtime profile for partial sort .. IMPALA-5870: Improve runtime profile for

[Impala-ASF-CR] IMPALA-5870: Improve runtime profile for partial sort

2017-09-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8123 ) Change subject: IMPALA-5870: Improve runtime profile for partial sort .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-27 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 9: I've started a run of the full EE

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-27 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 9: > Uploaded patch set 9. Pre-review

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-27 Thread Tim Wood (Code Review)
Hello Matthew Mulder, Michael Brown, David Knupp, Alex Behm, Mostafa Mokhtar, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8102 to look at the new patch set (#9). Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 5: Ping? -- To view, visit

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-5990: Part 1: JNI-based LZ4 de/compression

2017-09-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8150 ) Change subject: IMPALA-5990: Part 1: JNI-based LZ4 de/compression .. Patch Set 1: It looks like libraries like

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8151 ) Change subject: IMPALA-5307: Part 3: remove TODO from RCFile .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5307: Part 3: remove TODO from RCFile

2017-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8151 Change subject: IMPALA-5307: Part 3: remove TODO from RCFile .. IMPALA-5307: Part 3: remove TODO from RCFile Our RCFile implementations

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

2017-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. IMPALA-5307: Part 2: copy out strings in uncompressed Avro

[Impala-ASF-CR] IMPALA-5988: optimise MemPool::TryAllocate()

2017-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8145 ) Change subject: IMPALA-5988: optimise MemPool::TryAllocate() .. IMPALA-5988: optimise MemPool::TryAllocate() Testing: Ran core tests.

[Impala-ASF-CR] IMPALA-4252: Move runtime filters to ScanNode

2017-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8148 ) Change subject: IMPALA-4252: Move runtime filters to ScanNode .. Patch Set 1: (4 comments) Looks fine, just very minor comments. It

[Impala-ASF-CR] Move tests related to the old join node.

2017-09-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8153 ) Change subject: Move tests related to the old join node. .. Patch Set 2: Build started:

[Impala-ASF-CR] Move tests related to the old join node.

2017-09-27 Thread Alex Behm (Code Review)
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8153 to look at the new patch set (#2). Change subject: Move tests related to the old join node. .. Move

[Impala-ASF-CR] Move tests related to the old join node.

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8153 ) Change subject: Move tests related to the old join node. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Move tests related to the old join node.

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8153 ) Change subject: Move tests related to the old join node. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5951: test catalogd timeout fails to cause expected exception

2017-09-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8154 Change subject: IMPALA-5951: test_catalogd_timeout fails to cause expected exception .. IMPALA-5951: test_catalogd_timeout

[Impala-ASF-CR] Test cleanup related to the old join node.

2017-09-27 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8153 ) Change subject: Test cleanup related to the old join node. .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 2: > Thanks for fixing this. Can

[Impala-ASF-CR] Test cleanup related to the old join node.

2017-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8153 ) Change subject: Test cleanup related to the old join node. .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] Test cleanup related to the old join node.

2017-09-27 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8153 Change subject: Test cleanup related to the old join node. .. Test cleanup related to the old join node. Change-Id:

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-27 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8139 to look at the new patch set (#2). Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK')

[Impala-ASF-CR] IMPALA-5870: Improve runtime profile for partial sort

2017-09-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8123 ) Change subject: IMPALA-5870: Improve runtime profile for partial sort .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5310: Add COMPUTE STATS TABLESAMPLE.

2017-09-27 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8136 ) Change subject: IMPALA-5310: Add COMPUTE STATS TABLESAMPLE. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5310: Add COMPUTE STATS TABLESAMPLE.

2017-09-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8136 ) Change subject: IMPALA-5310: Add COMPUTE STATS TABLESAMPLE. .. Patch Set 1: (10 comments)