[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Add all build targets to CMake and speed up builds .. Add all build targets to CMake and speed up builds Use CMake's dependency resolution

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe,

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/120/ -- To

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: > Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/120/ Sorry, that was me

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe,

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/118/ -- To

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/117/ -- To

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 6: I'll give that a try - thanks for the tip. -- To view, visit

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 6: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe,

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 5: > I'm holding off on merging this until builds stabilise a little > more, since it's not a high

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 5: I'm holding off on merging this until builds stabilise a little more, since it's not a high

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe, visit

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 5: There were a couple of races exposed by running builds with different settings: * The shell

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 3: Confirmed I was able to build on all of our supported platforms with the change. Will wait

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 3: Code-Review+2 lgtm if that remaining test succeeds -- To view, visit

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 3: Code-Review+1 Rebase -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe,

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 2: (1 comment) I'll run a packaging test build

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 2: (1 comment) Have you tried this on a branch that still has thirdparty, e.g., packaging?

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 2: Code-Review+1 Not +2 because I think it could use a review from someone who knows Cmake much

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: Add all build targets to CMake and speed up builds .. Add all build targets to CMake and speed up builds Use CMake's dependency resolution always instead of

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4790/1/bin/make_impala.sh File

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 1: (5 comments) Have you tested this in a clean environment, maybe with Docker or Jenkins?