[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5585 To

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 12: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/5585 To

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 12: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/205/

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, Bharath Vissapragada, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#12). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/203/

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#11). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 10: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 10: Code-Review+1 (3 comments) The patch looks good to me overall. Especially

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#10). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#9). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 9: Added functional tests. -- To view, visit

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#8). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 7: (6 comments)

Re: [Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Marcel Kornacker
+Greg On Wed, Jan 11, 2017 at 3:22 PM, Tim Armstrong (Code Review) wrote: > Tim Armstrong has posted comments on this change. > > Change subject: IMPALA-1861: Simplify conditionals with constant conditions >

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 6: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. IMPALA-1861: Simplify conditionals with constant conditions When there are conditionals

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 4: (15 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. IMPALA-1861: Simplify conditionals with constant conditions When there are conditionals

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-07 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. IMPALA-1861: Simplify conditionals with constant conditions When there are conditionals

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 3: (21 comments) http://gerrit.cloudera.org:8080/#/c/5585/2//COMMIT_MSG