[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-27 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. IMPALA-4008: Don't bake ExprContext pointers into IR code To allow genearated code to

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 6: Will rebase before check-in. -- To view, visit http://gerrit.cloudera.org:8080/4390 To

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4390 to look at the new patch set (#7). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4390 to look at the new patch set (#6). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code ..

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4390/4/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4390/4/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-22 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4390 to look at the new patch set (#5). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code ..

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4390/3/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4390/3/be/src/exec/hash-table.cc File

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. IMPALA-4008: Don't bake ExprContext pointers into IR code To allow genearated code to be shared across

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4390/2/be/src/exec/aggregation-node.cc