[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417: make I/O buffer queue fixed-size This removes the dynamically-varying queue size

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7408 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1221/ -- To view,

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7408 to look at the new patch set (#9). Change subject: IMPALA-5417: make I/O buffer queue fixed-size ..

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 9: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7408 To unsubscribe,

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7408 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7408/7/be/src/runtime/disk-io-mgr-scan-range.cc

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-09-14 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7408 to look at the new patch set (#8). Change subject: IMPALA-5417: make I/O buffer queue fixed-size ..

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 7: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7408 To unsubscribe,

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 7: I thought about it some more and I'm not sure that adding meaningful timers is simple. We already

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 7: I did a pass and think it makes sense. Took me a while just to page the code back in, hadn't

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7408/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-01 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7408 to look at the new patch set (#7). Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417:

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/7408/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 6: Code-Review+1 Carry +1 from kwho -- To view, visit http://gerrit.cloudera.org:8080/7408 To

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7408/4/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7408 to look at the new patch set (#5). Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417:

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 3: Updated commit message with Perf. I did run benchmarks on a 16 node and it looked good. -- To

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417: make I/O buffer queue fixed-size This removes the dynamically-varying queue size behaviour in the

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 3: Did you run some perf tests to make sure that there is no regression ? -- To view, visit

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417: make I/O buffer queue fixed-size This removes the dynamically-varying queue size behaviour in the