[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7678 To

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. IMPALA-5644,IMPALA-5810: Min reservation improvements Rejects queries during admission

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 10: Code-Review+2 String msg changed and an existing test needed to be updated -- To view,

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1114/ -- To

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#10). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 9: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1109/

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1109/ -- To

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#9). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe,

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 8: looks like test_spilling.py will still require a lot of changes -- To view, visit

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe,

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#8). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 7: Code-Review+2 carrying Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/7678

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#7). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 6: Code-Review+2 (5 comments)

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7678 to look at the new patch set (#6). Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-5644,IMPALA-5810: Min reservation improvements

2017-08-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements .. Patch Set 5: Code-Review+2 (4 comments) Code looks fine but I think those (pre-existing) comments could