[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Talked with Michael offline. We agreed that it would be good to

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Thanks! -- To view, visit http://gerrit.cloudera.org:8080/7492

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: I wrote up a short page on the wiki per Henry's suggestion:

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Any more comments? -- To view, visit

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: OK. Thanks for the clarification. This kind of implicit rule is always

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: It would be great if someone could write the best-practice

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Matt's understanding matches mine - releasing resources in

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: > Isn't the general direction we are moving towards to not rely on

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Isn't the general direction we are moving towards to not rely on

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Code-Review+1 Seems like the right thing to do (i.e. control state

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7492 Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. IMPALA-5715: (potential mitigation)