[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Abandoned While this change works as expected, I think we can be more uniform in our

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 19: Code-Review+2 Thanks for the reviews. Carrying +2. -- To view,

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7955 to look at the new patch set (#19). Change subject: IMPALA-5881: Use native allocation while building catalog updates

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 18: (8 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 18: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 18: Taking a look now. -- To view, visit

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 18: Code-Review+1 (6 comments) Dimitris, any more comments?

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#18). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 17: (7 comments) Fixed a subtle bug in the test allocator.

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 17: (7 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#17). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 16: (14 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 16: (14 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 15: (1 comment) The test as such in current state is susceptible to OOM,

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#16). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 14: (13 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#15). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 14: (13 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (3 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (6 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (8 comments) Still looking at tests.

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#14). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: PS 13 adds more unit tests the NBAOS. -- To view, visit

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#13). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#12). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#11). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#10). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (14 comments) Redo'ing the test a little, will update the new PS

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (3 comments) Code looks good to me, still need to flesh out tests.

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (9 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 8: (2 comments) Flushing minor comments from patch #8 and switching to

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#9). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#8). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 7: (13 comments) Addressed comments other than the test file.

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 7: (15 comments) Still thinking about the warning/logging.

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#7). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 6: (2 comments) Fixed the tests. Figured out that the problem was with

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#6). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 4: (2 comments) Responding to comments, will look at code next.

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#5). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 1: (10 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#4). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves