[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. Change subject: Removed dead join inversion code from Analyzer. .. Abandoned As discussed with Alex, I'm abandoning this change and will submit a new change with a larger

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Sure I can take over. Most of these can be fixed using "Quick Fix" by the IDE. I'll take

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Code-Review-1 Do you want to take over the patch Bharath? Please keep in mind that some code (even

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: The above ones I pasted are apart from invertOuterJoinState() you removed here. -- To

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: I ran the code analysis tool from my IDE and found huge amount of un-used code in the

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4827 Change subject: Removed dead join inversion code from Analyzer. .. Removed dead join inversion code from Analyzer. Change-Id: