[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. Patch Set 4: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4352 To unsubscribe,

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-13 Thread Alex Behm (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4352 to look at the new patch set (#4). Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. ..

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4361/6/be/.impala.doxy File be/.impala.doxy:

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 4: Code-Review+2 Fixed the commit msg, carrying the +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 6: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4326 To

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4110: Apache RAT script on Impala tarballs.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4110: Apache RAT script on Impala tarballs. .. Patch Set 1: Separated from https://gerrit.cloudera.org/#/c/4361/ following a request by Alex. -- To view,

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. .. IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. While I'm here, fix as many of the warnings as

[Impala-ASF-CR] IMPALA-3491: Use unique db in test scanners.py and test aggregation.py

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py .. IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4125 To

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) I think we should avoid both forms of id inconsistency: Different tables with the same id, or the

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: I'd like you to run the small suite of cluster tests, but you can't yet until you rebase

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4404 Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. IMPALA-4122: qgen: fix bitrotted cluster unit tests There's a

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4326/3/be/src/exec/hash-table.h

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 4: Somehow Lars' earlier comments got deleted. Reproducing from my email: Patch

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4318/2/community.html File

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Jim Apple (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4318 to look at the new patch set (#3). Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

[Impala-ASF-CR] IMPALA-3491: Use unique db in test scanners.py and test aggregation.py

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4339 To

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#8). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh We used to

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Zoltan Ivanfi (Code Review)
Hello Lars Volker, Matthew Jacobs, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4094 to look at the new patch set (#16). Change subject: IMPALA-3973: add position and occurrence to instr()