[Impala-ASF-CR] IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges.

2017-02-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges. .. Patch Set 2: Verified+1 Passed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/265/ --

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""

2017-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for "RYW"" .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4809: Enable support for DECIMAL V2 in decimal casting.py

2017-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5989/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] Qualify min() in header

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Qualify min() in header .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5991 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 4: Code-Review+2 (1 comment) Carry +2.

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Sailesh Mukil (Code Review)
Hello Impala Public Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5972 to look at the new patch set (#4). Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 4: Code-Review-1 I did a build and got a lot of errors and it doesn't look like

[Impala-ASF-CR] IMPALA-4809: Enable support for DECIMAL V2 in decimal casting.py

2017-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5989/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-13 Thread Dan Hecht (Code Review)
Hello Michael Ho, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5952 to look at the new patch set (#13). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. Patch Set 11: Code-Review+1 (6 comments)

[Impala-ASF-CR] Make sure impala doesn't pickup the system's boost cmake module

2017-02-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Make sure impala doesn't pickup the system's boost cmake module .. Patch Set 1: (2 comments) Looks good to me, but would be good to track the info in a JIRA so

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. Patch Set 3: (2 comments) Addressed Laurel's comments.

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 4: > Uploaded patch set 5. Laurel, could you try building locally again?

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-13 Thread Ambreen Kazi (Code Review)
Hello Laurel Hale, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5957 to look at the new patch set (#4). Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. Patch Set 13: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5972

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5962 to look at the new patch set (#5). Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 5: > Jim, if you haven't done so already, I resolved the merge conflicts > here

[Impala-ASF-CR] Make sure impala doesn't pickup the system's boost cmake module

2017-02-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5994 Change subject: Make sure impala doesn't pickup the system's boost cmake module .. Make sure impala doesn't pickup the system's

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 5: Jim, if you haven't done so already, I resolved the merge conflicts here

[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5995 Change subject: A blog post about IMPALA-4916 .. A blog post about IMPALA-4916 While I'm here, fix IMPALA-4928 and allow the install

[Impala-ASF-CR] IMPALA-4809: Enable support for DECIMAL V2 in decimal casting.py

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5969/1/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges.

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges. .. Patch Set 1: Started pre-merge tests in dry-run mode so they will be ready ASAP but won't

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new patch set (#3). Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic This is part 2 of the

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 3: Code-Review+2 Thanks, Ambreen! -- To view, visit

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 2: > Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/264/

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5957/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5962 To

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/decimal-operators-ir.cc File

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-13 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5980 Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. IMPALA-4916: Fix maintenance of set of item sets in

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 4: Fixed a typo in keydef tag. -- To view, visit

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-13 Thread Ambreen Kazi (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5962 to look at the new patch set (#4). Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic