[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (3 comments) > (1 comment) > >

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 17: Csaba, it's hard to see, but the

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 18: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#18). Change subject: IMPALA-5736: Add impala-shell argument to set

[Impala-ASF-CR] IMPALA-6137: fix text scanner split delim mem mgmt

2017-11-02 Thread Tim Armstrong (Code Review)
Hello anujphadke, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8438 to look at the new patch set (#3). Change subject: IMPALA-6137: fix text scanner split delim mem mgmt ..

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-11-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-11-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-6137: fix text scanner split delim mem mgmt

2017-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8438 ) Change subject: IMPALA-6137: fix text scanner split delim mem mgmt .. Patch Set 2: (2 comments) The newest patch is my attempt at a

[Impala-ASF-CR] IMPALA-6137: fix text scanner split delim mem mgmt

2017-11-02 Thread Tim Armstrong (Code Review)
Hello anujphadke, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8438 to look at the new patch set (#4). Change subject: IMPALA-6137: fix text scanner split delim mem mgmt ..

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 18: > Csaba, it's hard to see, but

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-02 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: Any further comments on this

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 4: Made a first pass through this and it makes

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: What about Mostafa's

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. IMPALA-5736: Add impala-shell

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 18: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. IMPALA-5142 EventSequence displays

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 3: Code-Review+2 Carry +2 -- To

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2017-11-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: (1 comment) Thanks for the reviews! I'll report

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: I can take another look once you push

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-02 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: > Patch Set 4: > > > Patch Set

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#3). Change subject: IMPALA-2181: Add query option levels for

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-02 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 4: > Patch Set 4: > > What about

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#5). Change subject: IMPALA-2181: Add query option levels for

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 4: (62 comments)

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Correct log line in start-impala-cluster.py. Updated

[Impala-ASF-CR] Correct log line in start-impala-cluster.py.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8432 ) Change subject: Correct log line in start-impala-cluster.py. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. IMPALA-6136: Part 1: Query

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-02 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8317 to look at the new patch set (#4). Change subject: IMPALA-5976: Remove equivalence class computation in FE ..

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 5: (13 comments)

[Impala-ASF-CR] Install OpenJDK-dbg for development environments.

2017-11-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8431 ) Change subject: Install OpenJDK-dbg for development environments. .. Patch Set 2: Build started:

[Impala-ASF-CR] Install OpenJDK-dbg for development environments.

2017-11-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8431 ) Change subject: Install OpenJDK-dbg for development environments. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#4). Change subject: IMPALA-2181: Add query option levels for

[Impala-ASF-CR] Install OpenJDK-dbg for development environments.

2017-11-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8431 ) Change subject: Install OpenJDK-dbg for development environments. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6144: UpdateFilter()/PublishFilter() continue to run after query failure/cancellation

2017-11-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8455 Change subject: IMPALA-6144: UpdateFilter()/PublishFilter() continue to run after query failure/cancellation .. IMPALA-6144: