[Impala-ASF-CR] IMPALA-4435: Fix in-predicate-benchmark link error in release mode

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4964 Change subject: IMPALA-4435: Fix in-predicate-benchmark link error in release mode .. IMPALA-4435: Fix in-predicate-benchmark link

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4391: fix dropped statuses in scanners .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4938 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4849 To unsubscribe,

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. .. IMPALA-3586: Clean up union-node.h/cc to enable improvements. This patch does not

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4391: fix dropped statuses in scanners .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4938 To unsubscribe,

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4938 to look at the new patch set (#2). Change subject: IMPALA-4391: fix dropped statuses in scanners ..

[Impala-ASF-CR] IMPALA-4302,IMPALA-2379: constant expr arg fixes

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4838 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4941 to look at the new patch set (#4). Change subject: IMPALA-4266: Java udf returning string can give incorrect results

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add "Effective Coding Practices" doc to site .. Patch Set 2: I can see it being a blog post. Mainly I didn't think it fit on the wiki since it should be a

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 3: Code-Review+1 (2 comments) Thanks!

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4941 to look at the new patch set (#3). Change subject: IMPALA-4266: Java udf returning string can give incorrect results

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: Add "Effective Coding Practices" doc to site .. Add "Effective Coding Practices" doc to site This is a useful document that had floated around internally at

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 8: i'll pick this up once it has an overall +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add "Effective Coding Practices" doc to site .. Patch Set 1: Can you word-wrap the file so it's possible to review? Thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4849/5/be/src/exec/kudu-table-sink.h

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4961 Change subject: Add "Effective Coding Practices" doc to site .. Add "Effective Coding Practices" doc to site This is a useful document

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join.

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4960 Change subject: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. .. IMPALA-3167: Fix assignment of

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#18). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (1 comment) An additional high-level comment

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4856 To unsubscribe,

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: (11 comments) Some high-level comments before digging in deeper.

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. IMPALA-4338: test infra data migrator: include tables' primary keys in

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 4: (3 comments) Thanks for the review. Please see patch set 4.

[Impala-ASF-CR] IMPALA-4302,IMPALA-2379: constant expr arg fixes

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4302,IMPALA-2379: constant expr arg fixes .. Patch Set 4: (11 comments) Looks good. I think just comments about comments.

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. Patch Set 1: First pass on the review to make sure it's going in the right direction. I also wonder

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer Change-Id:

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 12: Rebased. Had to make some fixes to the UDF tests because of logical conflicts

[Impala-ASF-CR] IMPALA-4172: Switch to BlockLocation methods for disk IDs

2016-11-04 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded a new change for review. http://gerrit.cloudera.org:8080/4914 Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs .. IMPALA-4172: Switch to BlockLocation methods for disk IDs

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Thanks for the review, Taras. This *does* need GVO, which I'll make

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4936 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 4: > There is no point in sending it through GVO. Just submit it > directly Only committers can

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: There is no point in sending it through GVO. Just submit it directly -- To view,

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 7: Code-Review+1 (1 comment) Thanks for the review. I made the rename and

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-04 Thread Michael Brown (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4873 to look at the new patch set (#7). Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

[Impala-ASF-CR] IMPALA-4427: leopard: make DOCKER IMAGE NAME required

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required .. Patch Set 3: Thanks! Do you mind submitting this in the Gerrit WebUI since 1. GVO won't touch paths

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 8: (3 comments) Couple of naming questions, otherwise looks good.

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4918

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. IMPALA-4421: Send custom cluster & process failure test results to logs/

[Impala-ASF-CR] IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL

2016-11-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4338: test infra data migrator: include tables' primary keys in PostgreSQL .. Patch Set 2: Note this patched is based on

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 5: (12 comments) Nice cleanup

[Impala-ASF-CR] IMPALA-4406: Add cryptography export control notice

2016-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4406: Add cryptography export control notice .. Patch Set 3: Code-Review+2 Verified+1 (2 comments) Carry +2. No code changes, so verifying and

[Impala-ASF-CR] IMPALA-4406: Add cryptography export control notice

2016-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. Change subject: IMPALA-4406: Add cryptography export control notice .. IMPALA-4406: Add cryptography export control notice The ASF guidelines on crypto requires

[Impala-ASF-CR] IMPALA-4406: Add cryptography export control notice

2016-11-04 Thread Sailesh Mukil (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4940 to look at the new patch set (#3). Change subject: IMPALA-4406: Add cryptography export control notice ..

[Impala-ASF-CR] IMPALA-4391: fix dropped statuses in scanners

2016-11-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4391: fix dropped statuses in scanners .. Patch Set 1: Code-Review+1 Thanks for fixing this! -- To view, visit http://gerrit.cloudera.org:8080/4938 To

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable and sortable * Fix 'last accessed time'

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/service/impala-http-handler.cc

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 17: Code-Review+2 Ok thanks, it looked like this was just a rebase just wanted to check there wasn't

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 8: Why did the gvo fail? Were there any code changes in the latest patch set or

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. Patch Set 3: Verified-1 Build failed:

Re: [Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Thomas Tauber-Marshall
On Fri, Nov 4, 2016 at 11:26 AM Matthew Jacobs (Code Review) < ger...@cloudera.org> wrote: > Matthew Jacobs has posted comments on this change. > > Change subject: IMPALA-3725 Support Kudu UPSERT in Impala > .. > > > Patch Set

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4756 To

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 17: The GVO failed due to some Jenkins issue. Looks like the machine ran out of disk space:

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-04 Thread Matthew Jacobs (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4911 to look at the new patch set (#3). Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 8: Code-Review+1 (3 comments) +1 on the backend part.

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2016-11-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 1: (19 comments) http://gerrit.cloudera.org:8080/#/c/4944/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4756 to look at the new patch set (#8). Change subject: IMPALA-1169: Admission control info on the queries debug webpage

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Build failed:

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 8: (14 comments) Thanks for the reviews, please see PS8. I will update again once the

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-04 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4863 to look at the new patch set (#8). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ..

[Impala-ASF-CR] IMPALA-4266: Java udf returning string can give incorrect results

2016-11-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4266: Java udf returning string can give incorrect results .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4894 To

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. IMPALA-4379: Fix and test Kudu table type checking, follow up The first fix for

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking .. Patch Set 4: (6 comments)