[Impala-ASF-CR] IMPALA-4033: Improvements of partition DDL.

2016-12-15 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new change for review. http://gerrit.cloudera.org:8080/5535 Change subject: IMPALA-4033: Improvements of partition DDL. .. IMPALA-4033: Improvements of partition DDL. This commit makes ADD PARTITION o

[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-12-15 Thread Amos Bird (Code Review)
Amos Bird has abandoned this change. Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. Abandoned https://gerrit.cloudera.org/#/c/5535/ -- To view, visit http://gerrit.cloudera.org:8080/5137 To unsubsc

[Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool

2016-12-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5453 To unsubscribe

[Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool .. Patch Set 3: Code-Review+2 Carry Dan's +2 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. Patch Set 4: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-ge

[Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool

2016-12-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool .. Patch Set 2: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-exte

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert, upda

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-15 Thread Taras Bobrovytsky (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5093 to look at the new patch set (#9). Change subject: IMPALA-4467: Add support for DML statements in stress test ..

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-4163: Add sortby() query hint .. IMPALA-4163: Add sortby() query hint This change introduces the sortby() query plan hint for insert statements. When specifie

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 3: (18 comments) Thanks for the review. Please see PS4. http://gerrit.cloudera.org:8080/#/c/5051/3/fe/src/main/

[Impala-ASF-CR] IMPALA-3202,IMPALA-2298: rework scratch file I/O

2016-12-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2298: rework scratch file I/O .. Patch Set 15: (15 comments) Haven't made it all the way through the code, but had some comments about the heade

[Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool

2016-12-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5453 To unsubscribe

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 3: Code-Review+1 Carry +! -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5526/2/fe/src/main/j

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5526 to look at the new patch set (#3). Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5526/1/fe/src/main/j

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. IMPALA-4676: remove vestigial references to getBlockStorageLocations() API * the Blo

[Impala-ASF-CR](hadoop-next) IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 1: Code-Review+2 Verified+1 Committing to the hadoop-next branch to get

[Impala-ASF-CR](hadoop-next) IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 1: Code-Review+2 Verified+1 Committing to the hadoop-next branch to get

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 1: -Code-Review -Verified -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR](hadoop-next) IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5529 Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. IMPALA-4676: remove vestigial references t

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5526/1/fe/src

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5505 To unsub

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates The KuduScanN

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next .. Merge remote-tracking branch 'origin/master' into hadoop-next This needs the IMPALA-467

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5528 To

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next .. Merge remote-tracking branch 'origin/master' into hadoop-next This needs the IMPALA-4676 fix on to

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 3: > Uploaded patch set 3. Haven't addressed the latest comments yet. Will do it soon. -- To view, v

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-3977: TransmitData() should not block .. IMPALA-3977: TransmitData() should not block TransmitData() calls effectively block until an error occurs (e.g. dat

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next2

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next2 .. Patch Set 1: Code-Review+2 Verified+1 Just a merge commit to the hadoop-next branch. Confirmed

[Impala-ASF-CR](hadoop-next) Partially "IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API"

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Partially "IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API" .. Partially "IMPALA-4277: temporary hack to avoid compile e

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. Patch Set 4: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR](hadoop-next) Partially "IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API"

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Partially "IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API" .. Patch Set 1: Code-Review+2 Verified+1 This is just reverting a ch

[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-12-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5137/1/fe/src/main/java/org/apache/impala/an

[Impala-ASF-CR](hadoop-next) Partially "IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API"

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5527 Change subject: Partially "IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API" .. Partially "IMPALA-4277: t

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next2

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5528 Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next2 .. Merge remote-tracking branch 'origin/master' into hadoo

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5526 Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. IMPALA-4676: remove vestigial references t

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-15 Thread Dan Hecht (Code Review)
Dan Hecht has submitted this change and it was merged. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. IMPALA-4631: don't use floating point operations for time unit conversions Th

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-mgr.cc File be/

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4636: Correct Suse Linux distro string .. IMPALA-4636: Correct Suse Linux distro string The string should be suselinux12, not sles12. I

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5519 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4647: fix full data load with ninja .. Patch Set 3: Code-Review+2 Added an explanatory comment - carry +2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5476 to look at the new patch set (#3). Change subject: IMPALA-4647: fix full data load with ninja .. IMPALA-4647: fix full

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-mgr.cc File be/

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4649: add a mechanism to pass flags into make .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5480 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4649: add a mechanism to pass flags into make .. IMPALA-4649: add a mechanism to pass flags into make Testing: Tested that buildall.sh wo

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-3977: TransmitData() should not block .. IMPALA-3977: TransmitData() should not block TransmitData() calls effectively block until an error occurs (e.g. dat

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4647: fix full data load with ninja .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5476 To unsubscribe, visit http://gerrit.

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4647: fix full data load with ninja .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5476/2/buildall.sh File buildall.sh: Line 62: export

[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-12-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. Patch Set 1: Sorry for the confusion. As a general rule we do one commit per JIRA, in particular, for bug

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. Patch Set 4: Code-Review+2 Carrying +2. Thanks Tim for the quick reviews. -- To

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Bharath Vissapragada (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5523 to look at the new patch set (#4). Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space ...

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5523/3/be/src/common

[Impala-ASF-CR] IMPALA-4536: Decimal Parquet slots should be validated

2016-12-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5525 Change subject: IMPALA-4536: Decimal Parquet slots should be validated .. IMPALA-4536: Decimal Parquet slots should be validated

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5523/3/be/src

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4647: fix full data load with ninja .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5476/2/buildall.sh File buildall.sh: Line 62: export MAK

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. IMPALA-4673: Use --local_library_dir for tzdb startup scratch space Currently we har

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. IMPALA-4673: Use --local_library_dir for tzdb startup scratch space Currently we har

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5523/1/be/src/exprs

[Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool

2016-12-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5453 T

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements - Generate INSERT state

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5523/1/be/src/exprs/timezo

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

2016-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/5523 Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space .. IMPALA-4673: Use --local_library_dir for t

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4647: fix full data load with ninja .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5476/1//COMMIT_MSG Commit Message: Line 7: IMPALA-46

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4647: fix full data load with ninja .. IMPALA-4647: fix full data load with ninja This issues is that MAKE_CMD wasn't exported, so testdata/bin/copy-udfs-ud

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 2: Code-Review+2 carrying dimitris' +2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] CDH-48291: Fix flaky test TestRequestPoolService

2016-12-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: CDH-48291: Fix flaky test TestRequestPoolService .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5507/1/fe/src/test/java/org/apache/impa

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5519 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/125/ -- To view, vi

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5519 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread David Knupp (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5519 to look at the new patch set (#2). Change subject: IMPALA-4636: Correct Suse Linux distro string .. IMPALA-4636:

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5519/1//COMMIT_MSG Commit Message: Line 9: The stri

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4649: add a mechanism to pass flags into make .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5480 To unsubscri

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4649: add a mechanism to pass flags into make .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/124/ -- To v

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4649: add a mechanism to pass flags into make .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5480/2//COMMIT_MSG Commit Message: Line 13

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-15 Thread Tim Armstrong (Code Review)
Hello Jim Apple, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5480 to look at the new patch set (#3). Change subject: IMPALA-4649: add a mechanism to pass flags into make

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-sender.cc File b

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#3). Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements - Generate INSERT state

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 1: FWIW I did find 'suselinux' in an older version of IMPALA_CONFIG Also we have a similar OS check

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. IMPALA-4355: random query generator: modify statement execution flow to supp

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Patch Set 4: (1 comment) I made some adjustments to the discrepancy sear

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5519/1//COMMIT_MSG Commit Message: Line 9: The st

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4636: Correct Suse Linux distro string .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5519 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has abandoned this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Abandoned forgot to squash commit message; this was for https://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2016-12-15 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/5520 Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. IMPALA-4355: random query generat

[Impala-ASF-CR] IMPALA-4636: Correct Suse Linux distro string

2016-12-15 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5519 Change subject: IMPALA-4636: Correct Suse Linux distro string .. IMPALA-4636: Correct Suse Linux distro string The string should be suseli

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4649: add a mechanism to pass flags into make .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5480/2//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-4647: fix full data load with ninja

2016-12-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4647: fix full data load with ninja .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5476/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4647:

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2016-12-15 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#7). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. IMPALA-3989: Display skew warning for poorly formatted Parquet files Parquet files are scan

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2016-12-15 Thread Attila Jeges (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5400 to look at the new patch set (#7). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2016-12-15 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 6: (11 comments) http://gerrit.cloudera.org:8080/#/c/5400/6/be/src/exec/hdfs-p

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. IMPALA-3200: Implement suballocator for splitting buffers This is useful for situat

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 19: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4715 To unsubscr