[Impala-ASF-CR] Fix Lists import in ExprRewriter.java

2017-01-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Fix Lists import in ExprRewriter.java .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5606 To unsubscribe, visit

[Impala-ASF-CR] Fix Lists import in ExprRewriter.java

2017-01-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5606 Change subject: Fix Lists import in ExprRewriter.java .. Fix Lists import in ExprRewriter.java Change-Id:

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5556 To

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. The main problem was

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 28: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5141 To unsubscribe,

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4653: fix sticky config variable problem .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5545 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4653: fix sticky config variable problem .. IMPALA-4653: fix sticky config variable problem Previously we could get a developer's shell

[Impala-ASF-CR] IMPALA-4192: Avoid updating Expr's states from ExprContext

2017-01-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext .. Patch Set 2: (6 comments) i'm not sure this chunk of work is a meaningful intermediate

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/143/

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5556/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5556 to look at the new patch set (#4). Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4536: Decimal Parquet slots should be validated

2017-01-04 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4536: Decimal Parquet slots should be validated .. Patch Set 1: Thomas, Dan and I discussed this approach and concluded that it's better not to check

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3202: variable-length scratch file ranges

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: variable-length scratch file ranges .. Patch Set 5: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5597 To unsubscribe,

[Impala-ASF-CR] IMPALA-3202: variable-length scratch file ranges

2017-01-04 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5597 to look at the new patch set (#5). Change subject: IMPALA-3202: variable-length scratch file ranges .. IMPALA-3202:

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 28: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/142/ -- To

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 28: Code-Review+2 Needed to update test_set to reflect the changed default value of max_errors.

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5141 to look at the new patch set (#28). Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 27: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/138/

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 4: Code-Review+2 Rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4676: remove vestigial references to getBlockStorageLocations() API

2017-01-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4676: remove vestigial references to getBlockStorageLocations() API .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5526 To

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem

2017-01-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4653: fix sticky config variable problem .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5545 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3202: variable-length scratch file ranges

2017-01-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: variable-length scratch file ranges .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4643: Centralize all tags in a separate .ditamap file.

2017-01-04 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5599 Change subject: IMPALA-4643: Centralize all tags in a separate .ditamap file. .. IMPALA-4643: Centralize all tags in a separate

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4192: Avoid updating Expr's states from ExprContext

2017-01-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/5483/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4192: Avoid updating Expr's states from ExprContext

2017-01-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext .. Patch Set 2: > i'll take this on. Mid-air collision. -- To view, visit

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 4: > Any progress on this? There is no activity for over a month. If

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: > Patch Set 1: Code-Review+2 As a reminder, you can use

[Impala-ASF-CR] DOCS-1757

2017-01-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: DOCS-1757 .. Patch Set 1: (3 comments) Hi Ambreen! Thank you for creating this patch. http://gerrit.cloudera.org:8080/#/c/5594/1//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-3202: variable-length scratch file ranges

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3202: variable-length scratch file ranges .. IMPALA-3202: variable-length scratch file ranges This uses a simple approach where scratch ranges are managed

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 3: This is a long shot, but could IMPALA-4612 be related to this? -- To view, visit

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.

2017-01-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 27: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/138/ -- To

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5141 to look at the new patch set (#26). Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O ..

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 27: Code-Review+2 Carry Dan's +2 -- To view, visit http://gerrit.cloudera.org:8080/5141 To

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 4: Any progress on this? There is no activity for over a

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 25: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4689: Fix computation of last active time

2017-01-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4689: Fix computation of last active time .. IMPALA-4689: Fix computation of last active time The last active time in impala-server.cc#L1806

[Impala-ASF-CR] IMPALA-4689: Fix computation of last active time

2017-01-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4689: Fix computation of last active time .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5546 To unsubscribe, visit