[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 4: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/5950

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 4: Added decimal_v2 as a test dimension for decimal_casting.py. It's disabled for now as we

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5950 to look at the new patch set (#4). Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 ..

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5950 to look at the new patch set (#3). Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 ..

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5909 To

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI This commit

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5972 Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. IMPALA-4897: AnalysisException: specified cache

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. Patch Set 1: (1 comment) Changed how the logging works - it didn't quite work in the

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. IMPALA-4905: Reduce coordinator lock contention in RPC handler Fragment instances call

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4905: Reduce coordinator lock contention in RPC handler

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5971 Change subject: IMPALA-4905: Reduce coordinator lock contention in RPC handler .. IMPALA-4905: Reduce coordinator lock contention in

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#7). Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. IMPALA-4370: Divide and modulo result types for DECIMAL version V2 Implement the new DECIMAL

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Fix merge conflict .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5967 To unsubscribe, visit

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Fix merge conflict .. Fix merge conflict Commits fcc2d81 and 1335af3 conflicted. Change-Id: Ia5444d6b44b9aeea18f7861849513a2bde5c881f

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 2: Verified there is no perf regression with decimal_v2=false using following query: select

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/5969 Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. IMPALA-4546: Fix Moscow timezone conversion after 2014 In

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5840

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 6: Code-Review+1 carrying Sailesh's +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5840/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Matthew Jacobs (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5840 to look at the new patch set (#6). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 5: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic

2017-02-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.

2017-02-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5957/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 12: > I'm not sure the extra complexity of the UI is worth it. Without the UI, we'd have to

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 2: Code-Review+2 (2 comments) Please take a look at whether it makes sense to add coverage in

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: We also have test_decimal_casting.py. I haven't looked at it in detail but maybe there's

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix merge conflict .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5967 To unsubscribe, visit

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Fix merge conflict .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5967 To unsubscribe, visit

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Fix merge conflict .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/260/ -- To view, visit

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/5967 Change subject: Fix merge conflict .. Fix merge conflict Commits fcc2d81 and 1335af3 conflicted. Change-Id:

[Impala-ASF-CR] IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges.

2017-02-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges. .. Patch Set 1: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 12: > Marcel, you can make changes like you described just with a URL, > see test_web_pages.py

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: (16 comments) http://gerrit.cloudera.org:8080/#/c/5950/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 Currently, codegen supports converting type