[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6034 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5649 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/41/ -- To view, visit

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-16 Thread Matthew Jacobs (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5840 to look at the new patch set (#8). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

[Impala-ASF-CR] IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup

2017-02-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup .. Patch Set 2: Code-Review+1 Can't +2 because I'm not a component owner. So someone can

[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ

2017-02-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ .. Patch Set 1: Code-Review-1 > (2 comments) > > I made these changes but now when I push to gerrit I get: >

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. Patch Set 1: (6 comments) just some high level comments for now since this is WIP. would you

[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable

2017-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable .. IMPALA-4937: Remove unused kudu scanner keep alive variable gflag

[Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable

2017-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6021 To

[Impala-ASF-CR] IMPALA-3406: [DOCS] Remove stale and Cloudera-specific URLs

2017-02-16 Thread John Russell (Code Review)
John Russell has abandoned this change. Change subject: IMPALA-3406: [DOCS] Remove stale and Cloudera-specific URLs .. Abandoned The tags were also added in a separate gerrit. The changes to the FAQ aren't needed anymore

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: (5 comments) this is pretty cool. Got a couple of suggestions about organisation and

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6034/2//COMMIT_MSG Commit Message: Line 12:

[Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2

2017-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 .. Patch Set 2: Code-Review+1 (2 comments) +2 for backend and tests

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5649 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2

2017-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6038/1/be/src/exprs/aggregate-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2

2017-02-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 .. IMPALA-4821: Update AVG() for DECIMAL_V2 This change implements the DECIMAL_V2's behavior for AVG(). The major

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests

2017-02-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. IMPALA-4546: Fix Moscow timezone conversion after 2014 In 2014 Moscow timezone rules changed from

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. IMPALA-4546: Fix Moscow timezone conversion after 2014 In 2014 Moscow timezone rules changed from

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup .. Patch Set 2: private job succeeded -- To view, visit http://gerrit.cloudera.org:8080/6027

[Impala-ASF-CR] IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup

2017-02-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup .. IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup OpenSSL initialization

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-16 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. IMPALA-2328: Read support for min/max Parquet statistics This change adds support for skipping row

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. IMPALA-4546: Fix Moscow timezone conversion after 2014 In 2014 Moscow timezone rules changed from

[Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2

2017-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6038/1/be/src/exprs/aggregate-functions-ir.cc File

[Impala-ASF-CR] IMPALA-3405: [DOCS] Pare down upgrading section

2017-02-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3405: [DOCS] Pare down upgrading section .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6008/1/docs/topics/impala_upgrading.xml File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 14: (2 comments) Just closing off a couple of comments added by me in the last patch set.

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 15: (13 comments) http://gerrit.cloudera.org:8080/#/c/5649/14/docs/topics/impala_explain.xml File

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-02-16 Thread John Russell (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5649 to look at the new patch set (#15). Change subject: [DOCS] Major update to Impala + Kudu page .. [DOCS]

[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ

2017-02-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6003/1/docs/topics/impala_faq.xml File

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-02-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 3: Laurel, I am satisfied if you are. -- To view, visit http://gerrit.cloudera.org:8080/5663

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 11: (5 comments) > I have not updated the Python test yet, as that would require a > rebase. Python test

[Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2

2017-02-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6038 Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 .. IMPALA-4821: Update AVG() for DECIMAL_V2 This change implements the

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-02-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6037 Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. PREVIEW: IMPALA-3742: partitions INSERTs into Kudu