[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 3: (8 comments)

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu client version to 16dd6e4 .. Bump Kudu client version to 16dd6e4 Also sets the Java client version to 1.4.0-cdh5.12.0-SNAPSHOT

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/405/ -- To

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: failure seems unrelated to the change, it looks like

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/403/

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-03-21 Thread anujphadke (Code Review)
anujphadke has abandoned this change. Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Abandoned Had posted this for debugging and evaluating usage of decimalValue. -- To view, visit

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-03-21 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/6023/3//COMMIT_MSG Commit Message: PS3, Line 7:

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-03-21 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#4). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. IMPALA-4848: Add WIDTH_BUCKET() function Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f --- M

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Patch Set 1: Code-Review+2 Verified+1 I feel pretty good giving this a +2 myself (we discussed this

[Impala-ASF-CR] [DOCS] Genericize LZO setup instructions

2017-03-21 Thread John Russell (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6439 to look at the new patch set (#5). Change subject: [DOCS] Genericize LZO setup instructions .. [DOCS] Genericize

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6439/4/docs/topics/impala_txtfile.xml

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/404/ -- To view, visit

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-21 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6423 to look at the new patch set (#2). Change subject: Bump Kudu client version to 16dd6e4 .. Bump Kudu client

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/403/ -- To

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: Code-Review+1 I agree -- I don't see any downsides to scoping the connection fixture at test

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs Update all URLs in *keydefs* file

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe,

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/105/ -- To

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6452 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6453 Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. IMPALA-5079: Bump timeout for TestKuduOperations Tests seem to be

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Code-Review+1 My concerns are addressed. -- To view, visit

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 2: Code-Review+1 Built cleanly, fixes display as expected in all files after a spot check (both

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6452/1/docs/impala_keydefs.ditamap File

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs Update all URLs in *keydefs* file that point to

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 1: (2 comments) I need to set up dita locally before I give you any pluses, but here are my

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. Patch Set 1: The changes to the tags pointing to Impala issues were done by macro, so if the basic

[Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs

2017-03-21 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6452 Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs .. IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs Update all

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 4: Code-Review+1 Patch 4 builds cleanly and the content renders well in the html & pdf output.

[Impala-ASF-CR] Pass build type to Impala LZO.

2017-03-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Pass build type to Impala LZO. .. Patch Set 1: Fixes https://issues.apache.org/jira/browse/IMPALA-4699? -- To view, visit http://gerrit.cloudera.org:8080/6446 To

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Replace LZO setup instructions with placeholder .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6439/1/docs/topics/impala_txtfile.xml

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread John Russell (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6439 to look at the new patch set (#4). Change subject: [DOCS] Replace LZO setup instructions with placeholder .. [DOCS]

[Impala-ASF-CR] Pass build type to Impala LZO.

2017-03-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Pass build type to Impala LZO. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6446 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6440 To unsubscribe,

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] Genericize references to ODBC driver versions .. [DOCS] Genericize references to ODBC driver versions Make the statement about who uses

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/104/ -- To

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-21 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Genericize references to ODBC driver versions .. Patch Set 2: Code-Review+2 (1 comment) Combining resolution for Jim's comment with promoting Laurel's

[Impala-ASF-CR] [DOCS] Genericize references to ODBC driver versions

2017-03-21 Thread John Russell (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6440 to look at the new patch set (#2). Change subject: [DOCS] Genericize references to ODBC driver versions .. [DOCS]

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6450 Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id:

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6449 To unsubscribe, visit

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc3

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6447 To unsubscribe, visit

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc4

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6448 To unsubscribe, visit

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc3

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6447 Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 .. Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 Kudu tag

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6449 Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id:

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc4

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6448 Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 .. Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 Kudu tag

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#21). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches