[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 4: - I was reading the latest PS and I have question. Shouldn't we

[Impala-ASF-CR] IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

2017-03-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Implement Codegen for Union .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/6459/1/be/src/exec/union-node-ir.cc File

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-03-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. IMPALA-3203: Part 2: per-core free lists in buffer pool Add per-core lists of clean pages and free

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-03-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5958 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-03-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-03-23 Thread Joe McDonnell (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5958 to look at the new patch set (#4). Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu ..

[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

2017-03-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py .. Patch Set 1: (3 comments) Change looks ok to me, just some minor comments on the interface

[native-toolchain-CR] IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols

2017-03-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols .. Patch Set 1: (2 comments)

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-03-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. Patch Set 6: Fixed some unnecessary formatting changes and artefacts of the previous rebase. --

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-03-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. Patch Set 4: (2 comments) Looks like this accidentally reverted some deliberate changes we made.

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-03-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

2017-03-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/408/

[Impala-ASF-CR] IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

2017-03-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6465 To unsubscribe,

[Impala-ASF-CR] IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs

2017-03-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6464 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs

2017-03-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

2017-03-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6465 Change subject: IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu .. IMPALA-5111: Fix check when creating NOT NULL PK col in

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Implement Codegen for Union .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6459/1/be/src/exec/union-node.h File

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Implement Codegen for Union .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/6459/1/be/src/exec/union-node-ir.cc File

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs

2017-03-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs .. Patch Set 1: This LGTM. I'd like to hear Tim's thoughts before this is committed, since he has touched these

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. IMPALA-4669: [KUTIL] Add kudu_util library to the build. A few miscellaneous changes to allow

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Import kudu util library from kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@a1bfd7b .. IMPALA-4669: [KUTIL] Import kudu_util library from kudu@a1bfd7b Change-Id:

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@a1bfd7b .. IMPALA-4669: [SECURITY] Import Kudu security library from kudu@a1bfd7b The security

[Impala-ASF-CR] IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b .. IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b Change-Id:

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import FindKRPC.cmake from Apache Kudu. One minor linking

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. IMPALA-4758: (2/2) Impala-side changes to build with latest gutil Meant to be taken as a

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version to

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b * Copy gutil from Kudu * Change includes to remove kudu/

[Impala-ASF-CR] IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs

2017-03-23 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs .. Patch Set 1: BTW, there were a couple of references to sample code within the Impala test suite, and I was

[Impala-ASF-CR] IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs

2017-03-23 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6464 Change subject: IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs .. IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs Hide a couple of

[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings

2017-03-23 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6463 Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings .. IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-03-23 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 5: (15 comments)

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-03-23 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#5). Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet Before this

[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

2017-03-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6462 Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py .. IMPALA-5110: Add deb support to dump_breakpad_symbols.py

[native-toolchain-CR] IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols

2017-03-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6461 Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols .. IMPALA-4226, IMPALA-4227: bump max threads,