[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 8: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 3: (21 comments)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 14: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 8: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 14: (2 comments) looked through the headers and thrift and it

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 22: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 9: (6 comments)

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 8: > It's still technically accurate Yeah, I guess

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 20: (2 comments)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 8: Maybe this tooltip should be updated?

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: > That's a good point, will make that change.

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: (1 comment) Looked through the headers and

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 6: Code-Review+2 (1 comment) If you do decide to

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 19: (5 comments)

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 8: (23 comments)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 7: (37 comments)

[Impala-ASF-CR] IMPALA-6137: fix text scanner split delim mem mgmt

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8438 ) Change subject: IMPALA-6137: fix text scanner split delim mem mgmt .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6137: fix text scanner split delim mem mgmt

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8438 ) Change subject: IMPALA-6137: fix text scanner split delim mem mgmt .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 5: Sorry I didn't see the discussion on the JIRA about

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 6: (8 comments) Here's my last set of comments for this round.

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 6: (14 comments) Note to self: remaining files:

[Impala-ASF-CR] IMPALA-6137: fix text scanner split delim mem mgmt

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8438 ) Change subject: IMPALA-6137: fix text scanner split delim mem mgmt .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6137: fix text scanner split delim mem mgmt

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8438 ) Change subject: IMPALA-6137: fix text scanner split delim mem mgmt .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 7: > Looks good to me and it looks

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: Also, besides the RPCs, let's consider how to handle the

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: (2 comments) I think this path is worth continuing down.

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 2: Code-Review+2 Please update the

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 6: (37 comments) Next batch.

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: > Dan, did you want to have a look or

[Impala-ASF-CR] IMPALA-4964: Fix Decimal modulo overflow

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo overflow .. Patch Set 3: Tim, do you want a second pair of eyes on this? If not, could you

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 8: (3 comments) Michael, can you do the +2 for this

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 6: (5 comments) Some initial comments for this round.

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 14: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 14: Code-Review+1 Thanks. This approach looks okay

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-5307: Part 2: copy out strings in uncompressed Avro

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 11: (7 comments)

[Impala-ASF-CR] IMPALA-1575: Part 1: eagerly release query exec resources

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8303 ) Change subject: IMPALA-1575: Part 1: eagerly release query exec resources .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 4: Tim, can you do the +2 review for this one? -- To view,

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (16 comments) Some more comments, still going though.

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5957: print memory address, not memory

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8371 ) Change subject: IMPALA-5957: print memory address, not memory .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 11: Code-Review+1 (1 comment) BE

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 3: > I spoke to Greg and Alex yesterday, and we agreed

[Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 ) Change subject: IMPALA-5018: Error on decimal modulo or divide by zero .. Patch Set 2: (1 comment) In the JIRA, Greg made a comment about

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 4: What about common-metrics.cc? And then, I

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 2: Code-Review+1 (1 comment) Code change looks

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 2: Code-Review+2 Okay, thats fine. We can revisit if

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 8: Code-Review+2 (1 comment) Yes, this

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src/service.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src/service. .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 1: > (1 comment) But who is the caller of

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Reduce log spew from rpcz store.cc

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8285 ) Change subject: Reduce log spew from rpcz_store.cc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8285

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (34 comments) Another batch of comments...

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected()

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8255 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8242 ) Change subject: IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node .. Patch Set 3:

[Impala-ASF-CR] IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8242 ) Change subject: IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8242 ) Change subject: IMPALA-6030: Don't start coordinator specific thread pools if a node isn't a coordinator node .. Patch Set 1: It'd be

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: Is this a conflict free cherry-pick from something

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected()

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8255 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (17 comments) Some initial comments.

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Patch Set 1: > (1 comment) Correct, it

  1   2   3   4   5   6   7   8   9   10   >