[Impala-ASF-CR] Improvements to "Unknown disk-ID" warning

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: Improvements to "Unknown disk-ID" warning
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5828/1//COMMIT_MSG
Commit Message:

Line 7: Improvements to "Unknown disk-ID" warning
IMPALA-1427?


Line 9: This commit,
This patch seems fine. 

Another idea to consider:
I'm not really sure how useful it is to return these missing disk id warnings 
from scans. An alternative might be to report the number of missing disk ids in 
the explain plan of a query and throw away this runtime checking and warning 
through the existing path.


-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada 
Gerrit-Reviewer: Alex Behm 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Improvements to "Unknown disk-ID" warning

[Bharath Vissapragada (Code Review)]

Bharath Vissapragada has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5828

Change subject: Improvements to "Unknown disk-ID" warning
..

Improvements to "Unknown disk-ID" warning

This commit,
- Appends the table name to the "Unknown disk-ID" warning when
  disk IDs are missing, for supportability.

- Removes reference to enabling dfs block metadata configuration,
  since it doesn't apply anymore.

- Removes VolumeId terminology from the runtime profile.

Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
---
M be/src/exec/hdfs-scan-node-base.cc
M common/thrift/generate_error_codes.py
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/5828/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada