[Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.
David Knupp has posted comments on this change. Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 1: (3 comments) I did check that the same number of tests were collected (note -- that there is parallel change required for the tests in the aux directory that will be submitted as well.) These are the numbers, correcting for the problem with test_cancel_insert (IMPALA-4818). $ grep collected ~/tmp/pytest_collect_core* /home/dknupp/tmp/pytest_collect_core_IMPALA4750.txt:collecting ... collected 1830 items / 5 skipped /home/dknupp/tmp/pytest_collect_core_master.txt:collecting ... collected 1830 items / 5 skipped $ grep collected ~/tmp/pytest_collect_exhaustive* /home/dknupp/tmp/pytest_collect_exhaustive_IMPALA4750.txt:collecting ... collected 20881 items /home/dknupp/tmp/pytest_collect_exhaustive_master.txt:collecting ... collected 20881 items http://gerrit.cloudera.org:8080/#/c/5794/1//COMMIT_MSG Commit Message: PS1, Line 7: MPALA > Don't forget I. Done PS1, Line 9: that > extra word Done http://gerrit.cloudera.org:8080/#/c/5794/1/tests/experiments/test_targeted_perf.py File tests/experiments/test_targeted_perf.py: PS1, Line 33: TestMatrix > What's going on here? Weird. I don't know how that happened. For what it's worth, tests/experiments is not in the white list of directories defined in run-tests.py, so these tests never get run. Also, the name of the classmethod is even wrong -- add_test_dimensions() should be plural. So even if you try to run the tests in this module explicitly, this code still doesn't get executed. -- To view, visit http://gerrit.cloudera.org:8080/5794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David KnuppGerrit-Reviewer: David Knupp Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.
Jim Apple has posted comments on this change. Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5794/1//COMMIT_MSG Commit Message: PS1, Line 7: MPALA Don't forget I. -- To view, visit http://gerrit.cloudera.org:8080/5794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David KnuppGerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.
Jim Apple has posted comments on this change. Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 1: (2 comments) You checked that the same tests are selected to be run both before and after this patch? http://gerrit.cloudera.org:8080/#/c/5794/1//COMMIT_MSG Commit Message: PS1, Line 9: that extra word http://gerrit.cloudera.org:8080/#/c/5794/1/tests/experiments/test_targeted_perf.py File tests/experiments/test_targeted_perf.py: PS1, Line 33: TestMatrix What's going on here? -- To view, visit http://gerrit.cloudera.org:8080/5794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David KnuppGerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5794 Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes. .. MPALA-4750: Rename test infra classes so they don't mimic test classes. This patch addresses warning messages that from pytest re: the imported TestMatrix, TestVector, and TestDimension classes, which were being collected as potential test classes. The fix was to simply prepend the class names with Impala- git grep -l 'TestDimension' | xargs \ sed -i 's/TestDimension/ImpalaTestDimension/g' git grep -l 'TestMatrix' | xargs \ sed -i 's/TestMatrix/ImpalaTestMatrix/g' git grep -l 'TestVector' | xargs \ sed -i 's/TestVector/ImpalaTestVector/g' Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 --- M tests/authorization/test_grant_revoke.py M tests/catalog_service/test_catalog_service_client.py M tests/catalog_service/test_hms_failure.py M tests/catalog_service/test_large_num_partitions.py M tests/common/base_test_suite.py M tests/common/custom_cluster_test_suite.py M tests/common/impala_test_suite.py M tests/common/kudu_test_suite.py M tests/common/test_dimensions.py M tests/common/test_vector.py M tests/conftest.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_hive_parquet_timestamp_conversion.py M tests/custom_cluster/test_parquet_max_page_header.py M tests/custom_cluster/test_permanent_udfs.py M tests/custom_cluster/test_spilling.py M tests/data_errors/test_data_errors.py M tests/experiments/test_targeted_perf.py M tests/failure/test_failpoints.py M tests/metadata/test_compute_stats.py M tests/metadata/test_ddl.py M tests/metadata/test_ddl_base.py M tests/metadata/test_explain.py M tests/metadata/test_hdfs_encryption.py M tests/metadata/test_hdfs_permissions.py M tests/metadata/test_hidden_files.py M tests/metadata/test_hms_integration.py M tests/metadata/test_last_ddl_time_update.py M tests/metadata/test_load.py M tests/metadata/test_metadata_query_statements.py M tests/metadata/test_partition_metadata.py M tests/metadata/test_recover_partitions.py M tests/metadata/test_refresh_partition.py M tests/metadata/test_set.py M tests/metadata/test_show_create_table.py M tests/metadata/test_stale_metadata.py M tests/metadata/test_views_compatibility.py M tests/query_test/test_aggregation.py M tests/query_test/test_analytic_tpcds.py M tests/query_test/test_avro_schema_resolution.py M tests/query_test/test_cancellation.py M tests/query_test/test_chars.py M tests/query_test/test_compressed_formats.py M tests/query_test/test_decimal_casting.py M tests/query_test/test_decimal_queries.py M tests/query_test/test_delimited_text.py M tests/query_test/test_errorlog.py M tests/query_test/test_exprs.py M tests/query_test/test_hash_join_timer.py M tests/query_test/test_hbase_queries.py M tests/query_test/test_hdfs_caching.py M tests/query_test/test_hdfs_fd_caching.py M tests/query_test/test_insert.py M tests/query_test/test_insert_parquet.py M tests/query_test/test_insert_permutation.py M tests/query_test/test_invalid_test_header.py M tests/query_test/test_join_queries.py M tests/query_test/test_limit.py M tests/query_test/test_local_fs.py M tests/query_test/test_mem_usage_scaling.py M tests/query_test/test_mt_dop.py M tests/query_test/test_multiple_filesystems.py M tests/query_test/test_nested_types.py M tests/query_test/test_partitioning.py M tests/query_test/test_queries.py M tests/query_test/test_query_mem_limit.py M tests/query_test/test_query_opts.py M tests/query_test/test_rows_availability.py M tests/query_test/test_runtime_filters.py M tests/query_test/test_scanners.py M tests/query_test/test_scanners_fuzz.py M tests/query_test/test_scratch_limit.py M tests/query_test/test_sort.py M tests/query_test/test_timezones.py M tests/query_test/test_tpcds_queries.py M tests/query_test/test_tpch_nested_queries.py M tests/query_test/test_tpch_queries.py M tests/query_test/test_udfs.py M tests/stress/test_ddl_stress.py M tests/stress/test_mini_stress.py M tests/unittests/test_result_verifier.py 81 files changed, 455 insertions(+), 390 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/5794/1 -- To view, visit http://gerrit.cloudera.org:8080/5794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David KnuppGerrit-Reviewer: Jim Apple