[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-02-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/5161/13/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/13/be/src/exprs/scalar-fn-call.h File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-02-01 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/13/be/src/exprs/scalar-fn-call.h File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 13: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe,

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5161/12/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#13). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430:

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 12: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/11/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/11/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 11: (1 comment) Can you please address the question in agg-fn-evaluator.cc ? I can +1 afterwards.

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/5161/10/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 10: (7 comments) Looking good. Most comments about comments.

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2016-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2016-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2016-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5161 Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing