[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 18: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5584 To

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 18: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5584 To

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 18: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/218/ --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5584 to look at the new patch set (#18). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/217/ --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/217/ --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5584 To

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5584 to look at the new patch set (#17). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool ..

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 16: (1 comment) clang-tidy found this, but the Jenkins jobs that runs clang-tidy has confusing

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 16: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#15). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 13: (10 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 13: (10 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 12: (22 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 12: (19 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 12: Also fix a clang warning when the return value from assert_debug_death is ignored --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 11: Rebased to pick up the WARN_UNUSED_RESULT changes -- To view, visit

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 9: (33 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 9: (33 comments) Still have more to go (mostly in buffer-pool.cc) but here's another set of

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 7: (15 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level