[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 bahavior to help string for 'minidump path' flag

2017-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8164 )

Change subject: IMPALA-4736: Add SIGUSR1 bahavior to help string for 
'minidump_path' flag
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8164/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8164/1//COMMIT_MSG@7
PS1, Line 7: bahavior
behavior


http://gerrit.cloudera.org:8080/#/c/8164/1/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:

http://gerrit.cloudera.org:8080/#/c/8164/1/be/src/common/global-flags.cc@103
PS1, Line 103: requested by "
 : "user (SIGUSR1)
maybe it's worth spelling out a bit more - something like "requested by sending 
a SIGUSR1 signal to the process"



--
To view, visit http://gerrit.cloudera.org:8080/8164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0
Gerrit-Change-Number: 8164
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 28 Sep 2017 17:41:01 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 bahavior to help string for 'minidump path' flag

2017-09-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8164


Change subject: IMPALA-4736: Add SIGUSR1 bahavior to help string for 
'minidump_path' flag
..

IMPALA-4736: Add SIGUSR1 bahavior to help string for 'minidump_path' flag

Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0
---
M be/src/common/global-flags.cc
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/8164/1
--
To view, visit http://gerrit.cloudera.org:8080/8164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0
Gerrit-Change-Number: 8164
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer