[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6025 To unsubscribe,

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 17: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/381/ -- To

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 17: Code-Review+2 Forgot to update the alloc test. Made the tiny change to the test.

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#17). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Taras Bobrovytsky (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#17). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 16: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/378/

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 16: Thanks for all the reviews, Alex, Jim, MJ, Mostafa, Marcel! -- To view, visit

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 16: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/378/ -- To

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-15 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6025 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 15: (4 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#16). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#16). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#16). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 15: (4 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#15). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#15). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 14: (10 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-13 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#16). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 14: (10 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 13: (5 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-07 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-06 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#14). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 13: (5 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#13). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#13). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#13). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 12: (7 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#13). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 12: (7 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 12: Added skipping doublings in the merge case. -- To view, visit

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#12). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#12). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 11: > After talking to Alex, I completely rewrote the patch and reran the > benchmarks. The

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 11: After talking to Alex, I completely rewrote the patch and reran the benchmarks. The state

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#11). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#11). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-27 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#10). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-27 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#10). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-23 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6025 to look at the new patch set (#9). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage ..

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/6025/8//COMMIT_MSG Commit Message: PS8,

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 8: (9 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6025 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/6/be/src/exprs/aggregate-functions-ir.cc

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (3 comments) I'm still not convinced the new paths are necessarily, e.g. the case I

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6025/5/be/src/exprs/aggregate-functions-ir.cc

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/5/be/src/exprs/aggregate-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-18 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/5/be/src/exprs/aggregate-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/5/be/src/exprs/aggregate-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 4: (6 comments) I'm pretty happy with this patch.

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/2/be/src/exprs/aggregate-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: (17 comments) Marcel, I will run the targeted perf query later today.

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: Taras, why don't you run a targeted perf query to measure runtime overhead of 2x vs. 10x

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample functions (such as

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 1: (14 comments)

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 1: (14 comments) Did you verify the memory savings with a simple experiment?

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 1: I'll do a CR later tonight or tmr morning. -- To view, visit

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/6025 Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this