[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6812 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/824/ -- To view,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 11: > The build was failing because the return type of some new getters > was a "const bool" (instead

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#11). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Taras Bobrovytsky (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6812 to look at the new patch set (#11). Change subject: IMPALA-5036: Parquet count star optimization

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 10: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/823/ -- To view,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/823/ -- To view,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 10: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/822/ --

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/822/ -- To view,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 10: Code-Review+2 The previous build failed because an include was accidentally removed due to

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-04 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#10). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 9: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/820/ --

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/820/ -- To view,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 9: Code-Review+2 Rebased. Running a private build showed that there is a failing test in

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-07-02 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6812 to look at the new patch set (#9). Change subject: IMPALA-5036: Parquet count star optimization ..

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6812 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6812 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6812 to look at the new patch set (#8). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6812 to look at the new patch set (#7). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6812 to look at the new patch set (#7). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6812 to look at the new patch set (#6). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6812 to look at the new patch set (#6). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: Code-Review+1 (3 comments) Final nits. I'm happy with this patch. Dan should give the final +2

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/6812/4/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/6812/4/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 3: (28 comments) http://gerrit.cloudera.org:8080/#/c/6812/3/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6812/3/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 3: (26 comments) http://gerrit.cloudera.org:8080/#/c/6812/3/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 2: (17 comments) http://gerrit.cloudera.org:8080/#/c/6812/2/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 2: (23 comments) Code comments. Still going through the tests.

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (38 comments) http://gerrit.cloudera.org:8080/#/c/6812/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6812/1//COMMIT_MSG Commit Message: PS1, Line 10:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6812/1/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6812/1//COMMIT_MSG Commit Message: PS1, Line 10:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (36 comments) http://gerrit.cloudera.org:8080/#/c/6812/1//COMMIT_MSG Commit Message: PS1, Line 10:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/6812 Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of