[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan HechtGerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve readability of test program. Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Reviewed-on: http://gerrit.cloudera.org:8080/7801 Reviewed-by: Dan HechtTested-by: Impala Public Jenkins --- M be/src/service/session-expiry-test.cc 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1160/ -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan HechtGerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Code-Review+2 Looks like you uploaded this as a draft? You can upload it as a regular review and I can kick off a GVO. -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan HechtGerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has uploaded a new patch set (#3). Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve readability of test program. Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b --- M be/src/service/session-expiry-test.cc 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/7801/3 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan HechtGerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has uploaded a new patch set (#3). Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve readability of test program. Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b --- M be/src/service/session-expiry-test.cc 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/7801/3 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has restored this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Restored -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: restore Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has uploaded a new patch set (#2). Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve readability of test program. Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b --- M be/src/service/session-expiry-test.cc 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/7801/2 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has abandoned this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has abandoned this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Abandoned Need to use the old commit id -- To view, visit http://gerrit.cloudera.org:8080/7807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I46b4de40794c2b29668f6a41a50a757e4950daf6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has uploaded a new change for review. http://gerrit.cloudera.org:8080/7807 Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve readability of test program. Change-Id: I46b4de40794c2b29668f6a41a50a757e4950daf6 --- M be/src/service/session-expiry-test.cc 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/7807/1 -- To view, visit http://gerrit.cloudera.org:8080/7807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46b4de40794c2b29668f6a41a50a757e4950daf6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7801/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: PS1, Line 83: ( nit: extraneous parenthesis PS1, Line 89: (MAX_IDLE_TIMEOUT_MS/1000) nit: extraneous parenthesis and should have space around / -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan HechtGerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.
Pranay Singh has uploaded a new change for review. http://gerrit.cloudera.org:8080/7801 Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves giving names to constant values to improve readability of test program. Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b --- M be/src/service/session-expiry-test.cc 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/7801/1 -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh