[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7116/1/be/src/transport/TSasl.h File

[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. Patch Set 1: (11 comments) Looks pretty good. Have you confirmed this works with LDAP as well as GSSAPI?

[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. Patch Set 1: There's a lot more cleanup that can be done around the TSasl* layer, however, I think that

[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7116 Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. IMPALA-5221: Fix TSaslTransport negotiation order The