[Impala-ASF-CR] IMPALA-5467: disable flaky BenchmarkTest to unblock builds

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5467: disable flaky BenchmarkTest to unblock builds

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..


IMPALA-5467: disable flaky BenchmarkTest to unblock builds

Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Reviewed-on: http://gerrit.cloudera.org:8080/7135
Reviewed-by: Alex Behm 
Reviewed-by: Zach Amsden 
Tested-by: Impala Public Jenkins
---
M be/src/util/benchmark-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Zach Amsden: Looks good to me, but someone else must approve
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 

[Impala-ASF-CR] IMPALA-5467: disable flaky BenchmarkTest to unblock builds

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..


Patch Set 1:

Not sure. This happened on amazon EC2 vms so not sure what their TSC 
implementation looks like.

-- 
To view, visit http://gerrit.cloudera.org:8080/7135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5467: disable flaky BenchmarkTest to unblock builds

[Zach Amsden (Code Review)]

Zach Amsden has posted comments on this change.

Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..


Patch Set 1: Code-Review+1

Well since the fix, we know this isn't being caused by contention, any idea 
what could actually be causing it?

Do we have AMD or older Intel hardware with flaky TSCs in service that could 
explain this?

-- 
To view, visit http://gerrit.cloudera.org:8080/7135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5467: disable flaky BenchmarkTest to unblock builds

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5467: disable flaky BenchmarkTest to unblock builds

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/711/

-- 
To view, visit http://gerrit.cloudera.org:8080/7135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Zach Amsden 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5467: disable flaky BenchmarkTest to unblock builds

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7135

Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..

IMPALA-5467: disable flaky BenchmarkTest to unblock builds

Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
---
M be/src/util/benchmark-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/7135/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6aafbc620c1e839b07bf6020f9286ca5ee51197d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong