[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7400 To

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/864/

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7400 To

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#6). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/7400/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/7400/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: Thanks, Tim. Yeah I'll do another pass. -- To view, visit

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: (3 comments) Looks good aside from some minor things. MJ, I'm ok if you want to +2

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#5). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#5). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7400/3/be/src/exec/topn-node.h

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7400/3/be/src/exec/topn-node.h

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#4). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7400/3/be/src/exec/topn-node.cc

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#3). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 1: (19 comments) http://gerrit.cloudera.org:8080/#/c/7400/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 1: (4 comments) I didn't do a full pass, but I had some comments about the codegen

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 1: (15 comments) nice! http://gerrit.cloudera.org:8080/#/c/7400/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7400 Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old