[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..


IMPALA-5809: Relax max_minidumps in breakpad test

The change to address IMPALA-5769 added periodic cleaning for minidumps,
which got in the way of the other minidump tests.

This change sets max_minidumps to the default value (9) for all tests to
keep the cleanup thread from interfering, and then sets a smaller limit
where needed.

Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Reviewed-on: http://gerrit.cloudera.org:8080/7716
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 9 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1093/

-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Lars Volker (Code Review) 
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7716

to look at the new patch set (#3).

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..

IMPALA-5809: Relax max_minidumps in breakpad test

The change to address IMPALA-5769 added periodic cleaning for minidumps,
which got in the way of the other minidump tests.

This change sets max_minidumps to the default value (9) for all tests to
keep the cleanup thread from interfering, and then sets a smaller limit
where needed.

Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 9 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/7716/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7716/2//COMMIT_MSG
Commit Message:

Line 12: This change increases the max_minidumps for all tests to keep the
Seems stale.


-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Lars Volker (Code Review) 
Lars Volker has uploaded a new patch set (#2).

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..

IMPALA-5809: Relax max_minidumps in breakpad test

The change to address IMPALA-5769 added periodic cleaning for minidumps,
which got in the way of the other minidump tests.

This change increases the max_minidumps for all tests to keep the
cleanup thread from interfering, and then sets a smaller limit where
needed.

Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 9 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/7716/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5809: Relax max minidumps in breakpad test

2017-08-17 Thread Lars Volker (Code Review) 
Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7716

Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..

IMPALA-5809: Relax max_minidumps in breakpad test

The change to address IMPALA-5769 added periodic cleaning for minidumps,
which got in the way of the other minidump tests.

This change increases the max_minidumps for all tests to keep the
cleanup thread from interfering, and then sets a smaller limit where
needed.

Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/7716/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I977930ae87b8d4671a89c1e07ba76b12eb92fa55
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker