[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it
Impala Public Jenkins has submitted this change and it was merged. Change subject: Propagate HAVE_PIPE2 compile time value to files that use it .. Propagate HAVE_PIPE2 compile time value to files that use it The HAVE_PIPE2 is a variable that tracks whether a platform has the system function pipe2() present. This value was not propagated to the appropriate file that uses it, causing its value to always be 0, and the wrong branch to be taken at compile time. This fixes it by propagating the value to the file. Change-Id: I6cdc343da35a34be8d95fbea3543d080dbc1ec29 Reviewed-on: http://gerrit.cloudera.org:8080/7705 Reviewed-by: Henry RobinsonTested-by: Impala Public Jenkins --- M be/src/kudu/util/subprocess.cc 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Henry Robinson: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cdc343da35a34be8d95fbea3543d080dbc1ec29 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it
Impala Public Jenkins has posted comments on this change. Change subject: Propagate HAVE_PIPE2 compile time value to files that use it .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cdc343da35a34be8d95fbea3543d080dbc1ec29 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh MukilGerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it
Impala Public Jenkins has posted comments on this change. Change subject: Propagate HAVE_PIPE2 compile time value to files that use it .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1088/ -- To view, visit http://gerrit.cloudera.org:8080/7705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cdc343da35a34be8d95fbea3543d080dbc1ec29 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh MukilGerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it
Henry Robinson has posted comments on this change. Change subject: Propagate HAVE_PIPE2 compile time value to files that use it .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cdc343da35a34be8d95fbea3543d080dbc1ec29 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh MukilGerrit-Reviewer: Henry Robinson Gerrit-HasComments: No
[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7705 Change subject: Propagate HAVE_PIPE2 compile time value to files that use it .. Propagate HAVE_PIPE2 compile time value to files that use it The HAVE_PIPE2 is a variable that tracks whether a platform has the system function pipe2() present. This value was not propagated to the appropriate file that uses it, causing its value to always be 0, and the wrong branch to be taken at compile time. This fixes it by propagating the value to the file. Change-Id: I6cdc343da35a34be8d95fbea3543d080dbc1ec29 --- M be/src/kudu/util/subprocess.cc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/7705/1 -- To view, visit http://gerrit.cloudera.org:8080/7705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6cdc343da35a34be8d95fbea3543d080dbc1ec29 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil