[Impala-ASF-CR] Three misc webpage changes

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: Three misc webpage changes
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Three misc webpage changes

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged.

Change subject: Three misc webpage changes
..


Three misc webpage changes

1. Change the content width to 80% of the screen. Lots of our webpages
are very wide, and were squashed into the previous fixed width.

2. Fix a bug where some thread group tables weren't sortable or
searchable.

3. Make the backends list a searchable, sortable table.

Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Reviewed-on: http://gerrit.cloudera.org:8080/6045
Reviewed-by: Matthew Jacobs 
Tested-by: Impala Public Jenkins
---
M www/backends.tmpl
M www/common-header.tmpl
M www/thread-group.tmpl
3 files changed, 26 insertions(+), 8 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 

[Impala-ASF-CR] Three misc webpage changes

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: Three misc webpage changes
..


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/296/

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Three misc webpage changes

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: Three misc webpage changes
..


Patch Set 1: Code-Review+2

> Thanks for the reviews!
 > 
 > > seems fine but I don't really know jquery
 > 
 > If it makes it easier, this is basically C code - see e.g.
 > https://github.com/apache/incubator-impala/blob/master/www/sessions.tmpl
 > for another example of a sortable table already in master.
 > 

It does - thanks

 > > Is there a plan to migrate other HTML tables to DataTables?
 > (E.g., Queries, Query Locations, ...)
 > 
 > No particular plans - it's so easy to do I think anyone can do it
 > when they see a need.

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Three misc webpage changes

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: Three misc webpage changes
..


Patch Set 1:

Thanks for the reviews!

> seems fine but I don't really know jquery

If it makes it easier, this is basically C code - see e.g. 
https://github.com/apache/incubator-impala/blob/master/www/sessions.tmpl for 
another example of a sortable table already in master.

> Is there a plan to migrate other HTML tables to DataTables? (E.g., Queries, 
> Query Locations, ...)

No particular plans - it's so easy to do I think anyone can do it when they see 
a need.

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Three misc webpage changes

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Three misc webpage changes
..


Patch Set 1:

The changes here seem reasonable. Is there a plan to migrate other HTML tables 
to DataTables? (E.g., Queries, Query Locations, ...)

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Three misc webpage changes

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: Three misc webpage changes
..


Patch Set 1: Code-Review+1

seems fine but I don't really know jquery

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Three misc webpage changes

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: Three misc webpage changes
..


Patch Set 1:

Anyone want to take a quick look at this?

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: No