[GitHub] [incubator-iotdb] samperson1997 commented on issue #417: [IOTDB-234] Refactor TsFile storage on HDFS

samperson1997 commented on issue #417: [IOTDB-234] Refactor TsFile storage on HDFS URL: https://github.com/apache/incubator-iotdb/pull/417#issuecomment-542042012 > If you insist on this design, at least you should save the constructor. > And this test will show you that this is still

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334737366 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java ##

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334737388 ## File path: server/src/main/java/org/apache/iotdb/db/qp/constant/TqlParserConstant.java ##

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334737286 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java ##

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334736715 ## File path: server/src/test/java/org/apache/iotdb/db/qp/plan/LogicalPlanSmallTest.java ##

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334732471 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java ##

[GitHub] [incubator-iotdb] HTHou opened a new pull request #450: modify documents

HTHou opened a new pull request #450: modify documents URL: https://github.com/apache/incubator-iotdb/pull/450 Changed the structure of the User Guide. Fixed some link errors. This is an automated message from the Apache

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334729689 ## File path: server/src/test/java/org/apache/iotdb/db/qp/plan/LogicalPlanSmallTest.java

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334728810 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #339: [IOTDB-158] add metrics service

jixuan1989 commented on issue #339: [IOTDB-158] add metrics service URL: https://github.com/apache/incubator-iotdb/pull/339#issuecomment-542006976 One more thing, if there is a markdown document for introducing the tool, it could be better. You can put the markdown file under:

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #339: [IOTDB-158] add metrics service

jixuan1989 commented on issue #339: [IOTDB-158] add metrics service URL: https://github.com/apache/incubator-iotdb/pull/339#issuecomment-542006014 > Usually where we need something like this we download the resource as part of the build and take the parts we need and then reference that

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334715524 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

jixuan1989 commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334715385 ## File path: server/src/main/java/org/apache/iotdb/db/qp/constant/TqlParserConstant.java

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #445: generate cpp, go, and python thrift files under service-rpc

jixuan1989 commented on issue #445: generate cpp, go, and python thrift files under service-rpc URL: https://github.com/apache/incubator-iotdb/pull/445#issuecomment-541988772 > This is fine. > But programmers of other languages do not usually have maven installed, so I doubt whether

[GitHub] [incubator-iotdb] LeiRui commented on issue #440: reconstruct antlrv3 grammar to improve performance

LeiRui commented on issue #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#issuecomment-541576488 > "+" is not allowed to identify a positive value What about updating docs where necessary?

[GitHub] [incubator-iotdb] jt2594838 commented on issue #445: generate cpp, go, and python thrift files under service-rpc

jt2594838 commented on issue #445: generate cpp, go, and python thrift files under service-rpc URL: https://github.com/apache/incubator-iotdb/pull/445#issuecomment-541538420 This is fine. But programmers of other languages do not usually have maven installed, so I doubt whether this is

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #444: Add python client example in user guide

jt2594838 commented on a change in pull request #444: Add python client example in user guide URL: https://github.com/apache/incubator-iotdb/pull/444#discussion_r334359259 ## File path: docs/Documentation-CHN/OtherMaterial-Examples.md ## @@ -81,3 +81,172 @@ public class

[GitHub] [incubator-iotdb] jt2594838 commented on issue #444: Add python client example in user guide

jt2594838 commented on issue #444: Add python client example in user guide URL: https://github.com/apache/incubator-iotdb/pull/444#issuecomment-541537156 > considering #445 ? I suggest keeping these scripts as you can go without maven.

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically

jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334353560 ## File path: server/src/main/java/org/apache/iotdb/db/utils/DeviceIdCache.java ## @@ -0,0 +1,53 @@

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically

jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334354740 ## File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBAutoCreateSchemaIT.java ##

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically

jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334356054 ## File path: server/src/test/java/org/apache/iotdb/db/utils/TypeInferenceUtilsTest.java ## @@ -0,0

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically

jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334353987 ## File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBAutoCreateSchemaIT.java ##

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically

fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r33438 ## File path: server/src/main/java/org/apache/iotdb/db/utils/DeviceIdCache.java ## @@ -0,0 +1,53 @@

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically

fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334342259 ## File path: server/src/main/java/org/apache/iotdb/db/utils/DeviceIdCache.java ## @@ -0,0 +1,53 @@

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically

fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334341654 ## File path: server/src/main/java/org/apache/iotdb/db/qp/executor/QueryProcessExecutor.java ## @@

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically

fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334341958 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java ## @@ -48,6 +51,8 @@