[GitHub] [incubator-iotdb] LebronAl opened a new pull request #1422: [Distributed]remove unnecessary persistence

2020-06-24 Thread GitBox
LebronAl opened a new pull request #1422: URL: https://github.com/apache/incubator-iotdb/pull/1422 I found that it's unnecessary to persist meta after log's persistence in `SyncLogDequeSerializer`. Persisting meta is for security purposes.However, it is expensive to trigger the

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1416: [IOTDB-726] fix the lineNumber of mlog/snapshot is incorrect after restarting the server

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1416: URL: https://github.com/apache/incubator-iotdb/pull/1416#issuecomment-649174845 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1416=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1416: [IOTDB-726] fix the lineNumber of mlog/snapshot is incorrect after restarting the server

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1416: URL: https://github.com/apache/incubator-iotdb/pull/1416#issuecomment-648584583 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1416=false=BUG)

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1421: update merge recover

2020-06-24 Thread GitBox
qiaojialin merged pull request #1421: URL: https://github.com/apache/incubator-iotdb/pull/1421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-648913698 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1387=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#issuecomment-647891127 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1387=false=BUG)

[GitHub] [incubator-iotdb] zhanglingzhe0820 opened a new pull request #1421: update merge recover

2020-06-24 Thread GitBox
zhanglingzhe0820 opened a new pull request #1421: URL: https://github.com/apache/incubator-iotdb/pull/1421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-648859628 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-648636318 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444929928 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1684,6 +1739,77 @@ TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444929476 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1684,6 +1743,77 @@ TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444929324 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1684,6 +1743,77 @@ TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444929700 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1530,9 +1544,39 @@ private TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444928647 ## File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java ## @@ -914,8 +914,26 @@ public void insert(InsertPlan

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444928084 ## File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java ## @@ -914,8 +914,26 @@ public void insert(InsertPlan

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1408: move getSeriesSchemas to MManager

2020-06-24 Thread GitBox
mychaow commented on a change in pull request #1408: URL: https://github.com/apache/incubator-iotdb/pull/1408#discussion_r444879894 ## File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java ## @@ -915,227 +926,19 @@ public void insert(InsertPlan

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1409: Support partition removal

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#issuecomment-648710641 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1409=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1409: Support partition removal

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#issuecomment-648762910 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1409=false=BUG)

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1409: Support partition removal

2020-06-24 Thread GitBox
jt2594838 commented on a change in pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#discussion_r444798823 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -2410,4 +2410,58 @@ public boolean

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
jt2594838 commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444792728 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1684,6 +1743,77 @@ TSStatus

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1408: move getSeriesSchemas to MManager

2020-06-24 Thread GitBox
jt2594838 commented on a change in pull request #1408: URL: https://github.com/apache/incubator-iotdb/pull/1408#discussion_r444785081 ## File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java ## @@ -915,227 +926,19 @@ public void insert(InsertPlan

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1409: Support partition removal

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#issuecomment-648710641 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1409=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1409: Support partition removal

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#issuecomment-648688902 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1409=false=BUG)

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1409: Support partition removal

2020-06-24 Thread GitBox
jixuan1989 commented on a change in pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#discussion_r444754475 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -2410,4 +2410,58 @@ public

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-648697099 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-648683402 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1409: Support partition removal

2020-06-24 Thread GitBox
jt2594838 commented on a change in pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#discussion_r444751075 ## File path: server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java ## @@ -151,6 +151,7 @@ private SQLConstant() { public

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1409: Support partition removal

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#issuecomment-648688902 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1409=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1409: Support partition removal

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#issuecomment-647901412 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1409=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-648683402 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-648561545 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1418: [IOTDB-778] Do not handle measurement name with quotaion uniformly

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1418: URL: https://github.com/apache/incubator-iotdb/pull/1418#issuecomment-648620246 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1418=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1418: [IOTDB-778] Do not handle measurement name with quotaion uniformly

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1418: URL: https://github.com/apache/incubator-iotdb/pull/1418#issuecomment-648676791 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1418=false=BUG)

[GitHub] [incubator-iotdb] Genius-pig merged pull request #1420: Measurement with quote

2020-06-24 Thread GitBox
Genius-pig merged pull request #1420: URL: https://github.com/apache/incubator-iotdb/pull/1420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] Alima777 opened a new pull request #1420: Measurement with quote

2020-06-24 Thread GitBox
Alima777 opened a new pull request #1420: URL: https://github.com/apache/incubator-iotdb/pull/1420 Modify tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444719702 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1569,6 +1616,70 @@ TSStatus

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1418: [IOTDB-778] Do not handle measurement name with quotaion uniformly

2020-06-24 Thread GitBox
Alima777 commented on a change in pull request #1418: URL: https://github.com/apache/incubator-iotdb/pull/1418#discussion_r444704558 ## File path: tsfile/src/test/java/org/apache/iotdb/tsfile/read/common/PathTest.java ## @@ -41,7 +41,7 @@ public void construct() throws

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1416: [IOTDB-726] fix the lineNumber of mlog/snapshot is incorrect after restarting the server

2020-06-24 Thread GitBox
samperson1997 commented on a change in pull request #1416: URL: https://github.com/apache/incubator-iotdb/pull/1416#discussion_r444707007 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MLogWriter.java ## @@ -169,4 +169,12 @@ private void newLine() throws

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444706948 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1551,6 +1584,20 @@ TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444703105 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1530,9 +1544,38 @@ private TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444702688 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1667,6 +1710,18 @@ TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444700923 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1530,9 +1544,29 @@ private TSStatus

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444700377 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/DataGroupMember.java ## @@ -1610,6 +1623,34 @@ public void

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444699336 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/DataGroupMember.java ## @@ -1610,6 +1623,34 @@ public void

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

2020-06-24 Thread GitBox
Ring-k commented on a change in pull request #1387: URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444697825 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/DataGroupMember.java ## @@ -1073,7 +1072,12 @@ public void

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-648632851 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-648636318 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1409: Support partition removal

2020-06-24 Thread GitBox
jixuan1989 commented on a change in pull request #1409: URL: https://github.com/apache/incubator-iotdb/pull/1409#discussion_r444687142 ## File path: server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java ## @@ -151,6 +151,7 @@ private SQLConstant() { public

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-648563798 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-648632851 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1418: [IOTDB-778] Do not handle measurement name with quotaion uniformly

2020-06-24 Thread GitBox
sonarcloud[bot] commented on pull request #1418: URL: https://github.com/apache/incubator-iotdb/pull/1418#issuecomment-648620246 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1418=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1418: [IOTDB-778] Do not handle measurement name with quotaion uniformly

2020-06-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1418: URL: https://github.com/apache/incubator-iotdb/pull/1418#issuecomment-648575371 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1418=false=BUG)