Re: [PR] revert some change in restart it [iotdb]

2024-02-21 Thread via GitHub
Caideyipi commented on code in PR #12066: URL: https://github.com/apache/iotdb/pull/12066#discussion_r1498771534 ## integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java: ## @@ -264,29 +264,29 @@ private Map countNodeStatus(Map nodeStatus) {

[PR] revert some change in restart it [iotdb]

2024-02-21 Thread via GitHub
l2280212 opened a new pull request, #12066: URL: https://github.com/apache/iotdb/pull/12066 in https://github.com/apache/iotdb/pull/12022. I catch the exception while restart, then return boolean to mean restart result which made the error log not clear when it. -- This is an

Re: [PR] PBTree: Implement dual-buffer container for MNode management [iotdb]

2024-02-21 Thread via GitHub
linxt20 commented on code in PR #12048: URL: https://github.com/apache/iotdb/pull/12048#discussion_r1498758080 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/mnode/container/IMNodeChildBuffer.java: ## @@ -0,0 +1,39 @@ +/* +

Re: [PR] PBTree: Implement dual-buffer container for MNode management [iotdb]

2024-02-21 Thread via GitHub
linxt20 commented on code in PR #12048: URL: https://github.com/apache/iotdb/pull/12048#discussion_r1498752788 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/mnode/container/CachedMNodeContainer.java: ## @@ -425,14 +416,10

Re: [PR] PBTree: Implement dual-buffer container for MNode management [iotdb]

2024-02-21 Thread via GitHub
linxt20 commented on code in PR #12048: URL: https://github.com/apache/iotdb/pull/12048#discussion_r1498743075 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/memory/MemoryManager.java: ## @@ -322,6 +323,11 @@ public

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1498724127 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -172,6 +173,18 @@ public void shiftExecutor(boolean

Re: [PR] PBTree: Implement dual-buffer container for MNode management [iotdb]

2024-02-21 Thread via GitHub
MarcosZyk commented on code in PR #12048: URL: https://github.com/apache/iotdb/pull/12048#discussion_r1498699673 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/memory/MemoryManager.java: ## @@ -322,6 +323,11 @@ public

Re: [PR] Implement PageLifecycleManager for global page control [iotdb]

2024-02-21 Thread via GitHub
Cpaulyz merged PR #12008: URL: https://github.com/apache/iotdb/pull/12008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [IOTDB-6297] Optimize the distribute plan in the situation of `aggregation with align by device` [iotdb]

2024-02-21 Thread via GitHub
JackieTien97 merged PR #12043: URL: https://github.com/apache/iotdb/pull/12043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1498697767 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/CreateManyDatabasesProcedure.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
Caideyipi commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r149807 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software

Re: [PR] [IOTDB-6297] Optimize the distribute plan in the situation of `aggregation with align by device` [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #12043: URL: https://github.com/apache/iotdb/pull/12043#issuecomment-1958610633 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] [IOTDB-6298] Fix number overflow in group by time interval [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #12065: URL: https://github.com/apache/iotdb/pull/12065#issuecomment-1958612287 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] [IOTDB-6298] Fix number overflow in group by time interval [iotdb]

2024-02-21 Thread via GitHub
JackieTien97 opened a new pull request, #12065: URL: https://github.com/apache/iotdb/pull/12065 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1498572865 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/CreateManyDatabasesProcedure.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1498570658 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1498568958 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1498568569 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/CreateManyDatabasesProcedure.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the

Re: [PR] [IOTDB-6297] Optimize the distribute plan in the situation of `aggregation with align by device` [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #12043: URL: https://github.com/apache/iotdb/pull/12043#issuecomment-1958591191 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Implement new plan optimizer: PredicatePushDown [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #11859: URL: https://github.com/apache/iotdb/pull/11859#issuecomment-1958566297 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
Caideyipi commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1498520951 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/CreateManyDatabasesProcedure.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
Caideyipi commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1495369804 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/CreateManyDatabasesProcedure.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the

Re: [PR] [IOTDB-6297] Optimize the distribute plan in the situation of `aggregation with align by device` [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #12043: URL: https://github.com/apache/iotdb/pull/12043#issuecomment-1957317068 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Pipe meta sync: support meta data sync between different clusters [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #11794: URL: https://github.com/apache/iotdb/pull/11794#issuecomment-1957234629 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Pipe Meta: Fixed the bug that queue may be cleared after failed sync & clearing queue failure is not reported & may write consensus on dataNode after consensus closed [iotdb]

2024-02-21 Thread via GitHub
SteveYurongSu merged PR #12062: URL: https://github.com/apache/iotdb/pull/12062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [IOTDB-6297] Optimize the distribute plan in the situation of `aggregation with align by device` [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #12043: URL: https://github.com/apache/iotdb/pull/12043#issuecomment-1956813167 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Optimize the distribute plan in the situation of `aggregation with align by device` [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #12043: URL: https://github.com/apache/iotdb/pull/12043#issuecomment-1956469544 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1497297294 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1497284693 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1497279085 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/IManager.java: ## @@ -314,6 +314,8 @@ public interface IManager { */ TSStatus

Re: [PR] Pipe: Fixed the bug that CN cannot sense drop pipe failure in meta sync and may lead to constantly skip of drop pipe [iotdb]

2024-02-21 Thread via GitHub
SteveYurongSu merged PR #12059: URL: https://github.com/apache/iotdb/pull/12059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1497274763 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1497273983 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

[I] [Bug] 300: Modify template has not been supported. [iotdb]

2024-02-21 Thread via GitHub
qq461613840 opened a new issue, #12064: URL: https://github.com/apache/iotdb/issues/12064 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar. ### Version 1.3 ### Describe the bug and

Re: [PR] Add recover IT for Procedure, and delete ProcedureStore [iotdb]

2024-02-21 Thread via GitHub
liyuheng5 commented on code in PR #12045: URL: https://github.com/apache/iotdb/pull/12045#discussion_r1497257582 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/procedure/IoTDBProcedureIT.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

Re: [PR] Optimize the distribute plan in the situation of `aggregation with align by device` [iotdb]

2024-02-21 Thread via GitHub
sonarcloud[bot] commented on PR #12043: URL: https://github.com/apache/iotdb/pull/12043#issuecomment-1956294661 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Fix it which use 'merge' command [iotdb]

2024-02-21 Thread via GitHub
HTHou merged PR #12060: URL: https://github.com/apache/iotdb/pull/12060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: