Re: [PR] Implementation of device TTL [iotdb]

OneSizeFitsQuorum merged PR #12122: URL: https://github.com/apache/iotdb/pull/12122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1618726619 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java: ## @@ -389,19 +394,7 @@ public TShowDatabaseResp

Re: [PR] Implementation of device TTL [iotdb]

Caideyipi commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1618676830 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java: ## @@ -389,19 +394,7 @@ public TShowDatabaseResp

Re: [PR] Implementation of device TTL [iotdb]

SteveYurongSu commented on PR #12122: URL: https://github.com/apache/iotdb/pull/12122#issuecomment-2132581672 Please resolve all the conflicts :_) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582708491 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduleSummary.java: ## @@ -20,12 +20,21 @@

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582708244 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java: ## @@ -0,0 +1,389 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r158267 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java: ## @@ -516,6 +516,24 @@ public class IoTDBConfig { /** The interval of compaction

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582681168 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582678724 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582677960 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582676924 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/settle/SettleCompactionRecoverTest.java: ## @@ -0,0 +1,1137 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582667045 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/schema/source/DeviceSchemaSource.java: ## @@ -98,6 +100,8 @@ public void

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582658723 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582657290 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java: ## @@ -119,6 +119,9 @@ public class CommonConfig { */ private

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1582651501 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,335 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580446812 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java: ## @@ -0,0 +1,389 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580436509 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java: ## @@ -516,6 +516,24 @@ public class IoTDBConfig { /** The interval of compaction

Re: [PR] Implementation of device TTL [iotdb]

jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580434946 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

Re: [PR] Implementation of device TTL [iotdb]

jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1580434946 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms # default_ttl_in_ms=-1

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1579025404 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/TTLManager.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on PR #12122: URL: https://github.com/apache/iotdb/pull/12122#issuecomment-2074191685 > meta sync support The TTL synchronization between clusters is a relatively independent feature, which will be implemented in a subsequent new PR. -- This is an automated

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577350238 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/InnerSpaceCompactionTask.java: ## @@ -483,6 +476,13 @@

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577328532 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/MultiTsFileDeviceIterator.java: ## @@ -578,7 +583,27 @@

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577328114 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577311884 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/schema/source/DeviceSchemaSource.java: ## @@ -98,6 +100,8 @@ public void

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577310909 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577222419 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerWithFastPerformerTest.java: ## @@ -154,7 +154,7 @@

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577180788 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577175083 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577172088 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577167260 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576397733 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576047456 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576040934 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576037933 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576029400 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/TTLException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576021262 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java: ## @@ -119,6 +119,9 @@ public class CommonConfig { */ private

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576020607 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576019303 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576014872 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576011751 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576000190 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/settle/SettleCompactionRecoverTest.java: ## @@ -0,0 +1,1137 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575992167 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/TsFileResourceProgressIndexTest.java: ## @@ -277,6 +278,7 @@ public void

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575990673 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575929452 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575918974 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575911991 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java: ## @@ -0,0 +1,389 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575827285 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/InnerSpaceCompactionTask.java: ## @@ -283,30 +227,87 @@

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575818839 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/schema/DataNodeTTLCache.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575815531 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/TTLInfo.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575802400 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575781065 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575714841 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduleTaskManager.java: ## Review Comment:

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575710663 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/memory/SystemInfo.java: ## Review Comment: Resolved. -- This is an automated

Re: [PR] Implementation of device TTL [iotdb]

shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1565391622 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/memory/SystemInfo.java: ## Review Comment: Method `addCompactionMemoryCost(

Re: [PR] Implementation of device TTL [iotdb]

jt2594838 commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1574102114 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/InnerSpaceCompactionTask.java: ## @@ -283,30 +227,87 @@

Re: [PR] Implementation of device TTL [iotdb]

choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1571684329 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduler.java: ## @@ -100,11 +102,19 @@ public

Re: [PR] Implementation of device TTL [iotdb]

shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1566844267 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1566840398 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1566836737 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1565451572 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduleTaskManager.java: ## Review Comment: If

Re: [PR] Implementation of device TTL [iotdb]

SteveYurongSu commented on PR #12122: URL: https://github.com/apache/iotdb/pull/12122#issuecomment-2031080767 meta sync support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific