Re: [PR] Refactor Device Node Implementation in SchemaRegion [iotdb]

2023-12-06 Thread via GitHub
MarcosZyk merged PR #11661: URL: https://github.com/apache/iotdb/pull/11661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Refactor Device Node Implementation in SchemaRegion [iotdb]

2023-12-06 Thread via GitHub
MarcosZyk commented on code in PR #11661: URL: https://github.com/apache/iotdb/pull/11661#discussion_r1417100058 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/mnode/impl/CachedBasicInternalMNode.java: ## @@ -181,11 +164,31

Re: [PR] Refactor Device Node Implementation in SchemaRegion [iotdb]

2023-12-06 Thread via GitHub
MarcosZyk commented on code in PR #11661: URL: https://github.com/apache/iotdb/pull/11661#discussion_r1417099789 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/mnode/impl/CachedMeasurementMNode.java: ## @@ -34,7 +34,7 @@

Re: [PR] Refactor Device Node Implementation in SchemaRegion [iotdb]

2023-12-06 Thread via GitHub
Cpaulyz commented on code in PR #11661: URL: https://github.com/apache/iotdb/pull/11661#discussion_r1417008745 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/impl/MeasurementMNode.java: ## @@ -33,7 +33,7 @@ public class