[GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269486551 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] MyXOF merged pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
MyXOF merged pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269478041 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269477758 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269480675 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269480303 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] mdf369 edited a comment on issue #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 edited a comment on issue #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#issuecomment-477076324 test coverage: ![屏幕快照 2019-03-27 下午6 02

[GitHub] [incubator-iotdb] mdf369 commented on issue #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on issue #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#issuecomment-477076324 test coverage: ![屏幕快照 2019-03-27 下午6 02

[GitHub] [incubator-iotdb] mdf369 opened a new pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 opened a new pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114 Add a method to check whether a input path has already been set to storage level or not. This method will be used in Cluster module. It helps a node

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269552009 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269612335 ## File path:

[GitHub] [incubator-iotdb] Beyyes merged pull request #103: fix channel close bug in merge process

2019-03-27 Thread GitBox
Beyyes merged pull request #103: fix channel close bug in merge process URL: https://github.com/apache/incubator-iotdb/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269611175 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269614347 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269614088 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269622355 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269626277 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269631584 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269617158 ## File path:

[GitHub] [incubator-iotdb] fanhualta opened a new pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
fanhualta opened a new pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115 Due to iodtb cluster internal communication, it's necessary to add some serialization and deserialization methods of some non-query physical plan and add a unit test

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269605176 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269604325 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269621515 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269615977 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269615625 ## File path:

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269623940 ## File path: iotdb/src/main/java/org/apache/iotdb/db/qp/logical/sys/PropertyOperator.java ## @@ -56,6 +56,51 @@ public

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269625906 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/SystemLogOperator.java ## @@ -28,8 +28,8 @@

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269641915 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269640019 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269636567 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269637423 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269637797 ## File path:

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #116: check whether tsfile is deleted in ut

2019-03-27 Thread GitBox
jixuan1989 opened a new pull request #116: check whether tsfile is deleted in ut URL: https://github.com/apache/incubator-iotdb/pull/116 PLS Do not forget check the returned value of file.delete()!! This is an automated

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
fanhualta commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269645968 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/SystemLogOperator.java ## @@ -28,8 +28,8 @@

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
jixuan1989 commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269859836 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/CodecInstances.java ## @@ -0,0 +1,402 @@

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
fanhualta commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269861769 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/PhysicalPlanLogTransfer.java ## @@ -20,28

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
fanhualta commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269862750 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/CodecInstances.java ## @@ -0,0 +1,402 @@

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
fanhualta commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269864197 ## File path: iotdb/src/main/java/org/apache/iotdb/db/qp/logical/sys/AuthorOperator.java ## @@ -113,6 +114,99 @@

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269552401 ## File path:

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269618133 ## File path:

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269624347 ## File path: iotdb/src/main/java/org/apache/iotdb/db/qp/logical/sys/PropertyOperator.java ## @@ -56,6 +56,51 @@ public

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r26963 ## File path:

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
jixuan1989 commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269859242 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/CodecInstances.java ## @@ -0,0 +1,402 @@

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
jixuan1989 commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269859242 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/CodecInstances.java ## @@ -0,0 +1,402 @@

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
jixuan1989 commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269859500 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/CodecInstances.java ## @@ -0,0 +1,402 @@

[GitHub] [incubator-iotdb] wujysh commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
wujysh commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269860032 ## File path: iotdb/src/main/java/org/apache/iotdb/db/qp/logical/sys/MetadataOperator.java ## @@ -111,6 +111,42 @@

[GitHub] [incubator-iotdb] wujysh commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
wujysh commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269860072 ## File path: iotdb/src/main/java/org/apache/iotdb/db/qp/logical/sys/AuthorOperator.java ## @@ -113,6 +114,99 @@ public

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
jixuan1989 commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269860470 ## File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/transfer/CodecInstances.java ## @@ -0,0 +1,402 @@

[GitHub] [incubator-iotdb] jixuan1989 merged pull request #116: check whether tsfile is deleted in ut

2019-03-27 Thread GitBox
jixuan1989 merged pull request #116: check whether tsfile is deleted in ut URL: https://github.com/apache/incubator-iotdb/pull/116 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
jixuan1989 commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269840619 ## File path: iotdb/src/main/java/org/apache/iotdb/db/qp/logical/sys/PropertyOperator.java ## @@ -56,6 +56,51 @@

[GitHub] [incubator-iotdb] fanhualta opened a new pull request #118: Fix close bug of sync thread

2019-03-27 Thread GitBox
fanhualta opened a new pull request #118: Fix close bug of sync thread URL: https://github.com/apache/incubator-iotdb/pull/118 Fix the bug of sync thread resources may be not completely closed This is an automated message

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
jixuan1989 commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269841503 ## File path: iotdb/src/main/java/org/apache/iotdb/db/utils/ByteBufferUtils.java ## @@ -0,0 +1,59 @@ +/** + *

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #115: Serialize physical plan

2019-03-27 Thread GitBox
fanhualta commented on a change in pull request #115: Serialize physical plan URL: https://github.com/apache/incubator-iotdb/pull/115#discussion_r269849734 ## File path: iotdb/src/main/java/org/apache/iotdb/db/utils/ByteBufferUtils.java ## @@ -0,0 +1,59 @@ +/** + *

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-27 Thread GitBox
little-emotion commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r269415891 ## File path: