Re: [PR] [IOTDB-6259][RatisConsensus] Fix missing prefix in gauge metrics [iotdb]

2023-12-07 Thread via GitHub
OneSizeFitsQuorum merged PR #11677: URL: https://github.com/apache/iotdb/pull/11677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pipe: avoid useless pipe meta sync (stopped status) to DN [iotdb]

2023-12-07 Thread via GitHub
SteveYurongSu merged PR #11641: URL: https://github.com/apache/iotdb/pull/11641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] V1.2 fix bug of load TsFile [iotdb-docs]

2023-12-07 Thread via GitHub
wanghui42 opened a new pull request, #129: URL: https://github.com/apache/iotdb-docs/pull/129 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Pipe: avoid useless pipe meta sync (stopped status) to DN [iotdb]

2023-12-07 Thread via GitHub
VGalaxies commented on code in PR #11641: URL: https://github.com/apache/iotdb/pull/11641#discussion_r1419936716 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/task/PipeTaskCoordinator.java: ## @@ -118,11 +120,18 @@ public TSStatus

Re: [PR] [IOTDB-6252] Greedy CopySet allocation algorithm [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11572: URL: https://github.com/apache/iotdb/pull/11572#issuecomment-1846591729 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [I] [Bug] 1.2.2版本SQL 命令行终端 (CLI)参数不生效 [iotdb]

2023-12-07 Thread via GitHub
bigdata-spec closed issue #11657: [Bug] 1.2.2版本SQL 命令行终端 (CLI)参数不生效 URL: https://github.com/apache/iotdb/issues/11657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Bug] 1.2.2版本SQL 命令行终端 (CLI)参数不生效 [iotdb]

2023-12-07 Thread via GitHub
bigdata-spec commented on issue #11657: URL: https://github.com/apache/iotdb/issues/11657#issuecomment-1846601594 > #11039 这个参数在 1.2.2 里被移除了,因为如果设置的过大,CLI有OOM的风险 文档上的描述确实需要修改一下 非常感谢回答。 -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Pipe: RPC datastructures for schema pipe [iotdb]

2023-12-07 Thread via GitHub
DanielWang2035 opened a new pull request, #11680: URL: https://github.com/apache/iotdb/pull/11680 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [RatisConsensus] Retry Read Requests on StatusRuntimeException [iotdb]

2023-12-07 Thread via GitHub
OneSizeFitsQuorum merged PR #11679: URL: https://github.com/apache/iotdb/pull/11679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [RatisConsensus] Retry Read Requests on StatusRuntimeException [iotdb]

2023-12-07 Thread via GitHub
SzyWilliam opened a new pull request, #11679: URL: https://github.com/apache/iotdb/pull/11679 StatusRuntimeException will be thrown if the leader is offline (gRPC cannotconnect to the peer) We can still retry in case it's a temporary network partition. -- This is an automated message

Re: [PR] [IOTDB-6252] Greedy CopySet allocation algorithm [iotdb]

2023-12-07 Thread via GitHub
OneSizeFitsQuorum merged PR #11572: URL: https://github.com/apache/iotdb/pull/11572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix reconnect bug for JDBC [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11675: URL: https://github.com/apache/iotdb/pull/11675#issuecomment-1846442424 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] Fix reconnect bug for JDBC [iotdb]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #11675: URL: https://github.com/apache/iotdb/pull/11675#issuecomment-1846466458 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11675?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `7

Re: [PR] Pipe: avoid useless pipe meta sync (stopped status) to DN [iotdb]

2023-12-07 Thread via GitHub
SteveYurongSu commented on code in PR #11641: URL: https://github.com/apache/iotdb/pull/11641#discussion_r1419924550 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/task/PipeTaskCoordinator.java: ## @@ -118,11 +120,18 @@ public TSStatus

Re: [PR] update iotdb-deploy doc [iotdb-docs]

2023-12-07 Thread via GitHub
qiaojialin merged PR #72: URL: https://github.com/apache/iotdb-docs/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Rest configuration is adjusted from iotdb-common.properties to iotdb-datanode.properties [iotdb-docs]

2023-12-07 Thread via GitHub
qiaojialin merged PR #115: URL: https://github.com/apache/iotdb-docs/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846499271 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11671?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention:

Re: [PR] [IOTDB-6263] Enhance IoTDBPartitionCreationIT [iotdb]

2023-12-07 Thread via GitHub
OneSizeFitsQuorum merged PR #11676: URL: https://github.com/apache/iotdb/pull/11676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846513117 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] Fix reconnect bug for JDBC [iotdb]

2023-12-07 Thread via GitHub
JackieTien97 merged PR #11675: URL: https://github.com/apache/iotdb/pull/11675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1846478411 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[PR] Rest service code optimization and fixed insertRecords error prompt returning null issue [iotdb]

2023-12-07 Thread via GitHub
CloudWise-Lukemiao opened a new pull request, #11678: URL: https://github.com/apache/iotdb/pull/11678 Rest is compatible with previous version configurations and fixed insertRecords error prompt returning null issue and rest v1 remove insertRecords -- This is an automated message from

Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1844862239 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[PR] fix error path [iotdb-docs]

2023-12-07 Thread via GitHub
l2280212 opened a new pull request, #128: URL: https://github.com/apache/iotdb-docs/pull/128 The MQTT configurations have been moved to iotdb-common.properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] update rest insertRecords doc [iotdb-docs]

2023-12-07 Thread via GitHub
qiaojialin merged PR #124: URL: https://github.com/apache/iotdb-docs/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [IOTDB-6252] Greedy CopySet allocation algorithm [iotdb]

2023-12-07 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #11572: URL: https://github.com/apache/iotdb/pull/11572#discussion_r1418307084 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocator.java: ## @@ -0,0 +1,183 @@

Re: [PR] SeriesScanUtil support predicate pushdown [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11671: URL: https://github.com/apache/iotdb/pull/11671#issuecomment-1845015122 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] Optimize the efficiency of map-related code in IRegionGroupAllocator [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11673: URL: https://github.com/apache/iotdb/pull/11673#issuecomment-1845024127 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[PR] Optimize the efficiency of map-related code in IRegionGroupAllocator [iotdb]

2023-12-07 Thread via GitHub
OneSizeFitsQuorum opened a new pull request, #11673: URL: https://github.com/apache/iotdb/pull/11673 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Optimize the efficiency of map-related code in IRegionGroupAllocator [iotdb]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #11673: URL: https://github.com/apache/iotdb/pull/11673#issuecomment-1845082809 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11673?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `5

[PR] Pipe Schema: Added pipe enrich planNode logic to enable pipe request detection in order to configure "forwarding-pipe-request" in pipe SQL. [iotdb]

2023-12-07 Thread via GitHub
Caideyipi opened a new pull request, #11672: URL: https://github.com/apache/iotdb/pull/11672 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] [IOTDB-6263] Enhance IoTDBPartitionCreationIT [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11676: URL: https://github.com/apache/iotdb/pull/11676#issuecomment-1845439618 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [IOTDB-6218] Rename storage_query_schema_consensus_free_memory_proportion to datanode_memory_proportion [iotdb-docs]

2023-12-07 Thread via GitHub
qiaojialin merged PR #114: URL: https://github.com/apache/iotdb-docs/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [IOTDB-6174] Support ColumnInjectOperator for '__endTime' output [iotdb]

2023-12-07 Thread via GitHub
JackieTien97 merged PR #11668: URL: https://github.com/apache/iotdb/pull/11668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [IOTDB-6252] Greedy CopySet allocation algorithm [iotdb]

2023-12-07 Thread via GitHub
CRZbulabula commented on code in PR #11572: URL: https://github.com/apache/iotdb/pull/11572#discussion_r1418901924 ## iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocatorTest.java: ## @@ -0,0 +1,209 @@

Re: [PR] [IOTDB-6252] Greedy CopySet allocation algorithm [iotdb]

2023-12-07 Thread via GitHub
CRZbulabula commented on code in PR #11572: URL: https://github.com/apache/iotdb/pull/11572#discussion_r1418901172 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocator.java: ## @@ -0,0 +1,183 @@ +/* +

Re: [PR] Add Telegraf IoTDB Output Plugin Usage doc [iotdb-docs]

2023-12-07 Thread via GitHub
qiaojialin merged PR #123: URL: https://github.com/apache/iotdb-docs/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(authority): error break line [iotdb-docs]

2023-12-07 Thread via GitHub
qiaojialin merged PR #127: URL: https://github.com/apache/iotdb-docs/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix error path [iotdb-docs]

2023-12-07 Thread via GitHub
qiaojialin merged PR #128: URL: https://github.com/apache/iotdb-docs/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix reconnect bug for JDBC [iotdb]

2023-12-07 Thread via GitHub
JackieTien97 opened a new pull request, #11675: URL: https://github.com/apache/iotdb/pull/11675 We need to regenerate a statement id while reconnecting, otherwise we will get the following error msg.

Re: [PR] Fix reconnect bug for JDBC [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11675: URL: https://github.com/apache/iotdb/pull/11675#issuecomment-1845215578 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [IOTDB-6252] Greedy CopySet allocation algorithm [iotdb]

2023-12-07 Thread via GitHub
sonarcloud[bot] commented on PR #11572: URL: https://github.com/apache/iotdb/pull/11572#issuecomment-1845280983 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] Rest is compatible with previous version configurations and fixes null issues with insertRecords return information [iotdb]

2023-12-07 Thread via GitHub
CloudWise-Lukemiao closed pull request #11674: Rest is compatible with previous version configurations and fixes null issues with insertRecords return information URL: https://github.com/apache/iotdb/pull/11674 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [IOTDB-6252] Greedy CopySet allocation algorithm [iotdb]

2023-12-07 Thread via GitHub
CRZbulabula commented on code in PR #11572: URL: https://github.com/apache/iotdb/pull/11572#discussion_r1418901541 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocator.java: ## @@ -0,0 +1,183 @@ +/* +

Re: [PR] Optimize the efficiency of map-related code in IRegionGroupAllocator [iotdb]

2023-12-07 Thread via GitHub
OneSizeFitsQuorum merged PR #11673: URL: https://github.com/apache/iotdb/pull/11673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [IOTDB-6259][RatisConsensus] Fix missing prefix in gauge metrics [iotdb]

2023-12-07 Thread via GitHub
SzyWilliam opened a new pull request, #11677: URL: https://github.com/apache/iotdb/pull/11677 The change here introduce a bug: https://github.com/apache/iotdb/pull/11618/files#diff-f67276fe8d5ea2d3765257390efdd8df1d8185ee70c2445dcd8689ff0901384eL165 The prefix is missing and the metrics

Re: [PR] [IOTDB-6259] Bump ratis version to 3.0.0 [iotdb]

2023-12-07 Thread via GitHub
SzyWilliam commented on code in PR #11618: URL: https://github.com/apache/iotdb/pull/11618#discussion_r1419113639 ## iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/metrics/IoTDBMetricRegistry.java: ## @@ -161,93 +145,22 @@ public boolean remove(String name)