Re: [I] [Bug] iotdb 压缩线程处理异常之后,会无限处理错误数据。手动删除对应的序列也没用 [iotdb]

2024-04-28 Thread via GitHub
shuwenwei commented on issue #12360: URL: https://github.com/apache/iotdb/issues/12360#issuecomment-2081355274 > 1.3.0写入的序列,这个是升级1.3.1之后还有。 发现还是有报错之后,删除了原来的序列,重新自动生成该序列。错误还是一直有。 我复现出来了,可能是有点问题 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Add hot reload for IoTConsensus transit snapshot rate limiter and fix init [iotdb]

2024-04-28 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12430: URL: https://github.com/apache/iotdb/pull/12430#discussion_r1582054253 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java: ## @@ -1052,6 +1053,11 @@ public void loadProperties(Properties

Re: [PR] Add hot reload for IoTConsensus transit snapshot rate limiter and fix init [iotdb]

2024-04-28 Thread via GitHub
OneSizeFitsQuorum merged PR #12430: URL: https://github.com/apache/iotdb/pull/12430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Ensuring IoTconsensus data consistency during region migration [iotdb]

2024-04-28 Thread via GitHub
OneSizeFitsQuorum merged PR #12438: URL: https://github.com/apache/iotdb/pull/12438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-28 Thread via GitHub
HTHou commented on code in PR #12271: URL: https://github.com/apache/iotdb/pull/12271#discussion_r1582164901 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java: ## @@ -1105,18 +1103,15 @@ private void

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-28 Thread via GitHub
HTHou commented on PR #12271: URL: https://github.com/apache/iotdb/pull/12271#issuecomment-2081494979 > It's better to add some tests about getting InsertRowsNode in the ConsensusReqReaderTest. All done. PTAL -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Revert "Normalize LoadCache interfaces (#12421)" [iotdb]

2024-04-28 Thread via GitHub
sonarcloud[bot] commented on PR #12440: URL: https://github.com/apache/iotdb/pull/12440#issuecomment-2081536789 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

[PR] Fix insertion cross space compaction recover null pointer exception [iotdb]

2024-04-28 Thread via GitHub
shuwenwei opened a new pull request, #12439: URL: https://github.com/apache/iotdb/pull/12439 ## Description Fix insertion cross space compaction recover null pointer exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-28 Thread via GitHub
HTHou commented on code in PR #12271: URL: https://github.com/apache/iotdb/pull/12271#discussion_r1582164946 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/recover/WALNodeRecoverTask.java: ## @@ -155,7 +155,8 @@ private long[]

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-28 Thread via GitHub
sonarcloud[bot] commented on PR #12421: URL: https://github.com/apache/iotdb/pull/12421#issuecomment-2081442382 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-28 Thread via GitHub
OneSizeFitsQuorum merged PR #12421: URL: https://github.com/apache/iotdb/pull/12421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-28 Thread via GitHub
codecov[bot] commented on PR #12271: URL: https://github.com/apache/iotdb/pull/12271#issuecomment-2081510829 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12271?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Revert "Normalize LoadCache interfaces (#12421)" [iotdb]

2024-04-28 Thread via GitHub
OneSizeFitsQuorum merged PR #12440: URL: https://github.com/apache/iotdb/pull/12440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix the conflict between Files.walk and delete file && Catch UncheckedIOException && some other bugs [iotdb]

2024-04-28 Thread via GitHub
OneSizeFitsQuorum merged PR #12429: URL: https://github.com/apache/iotdb/pull/12429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-28 Thread via GitHub
HeimingZ commented on code in PR #12271: URL: https://github.com/apache/iotdb/pull/12271#discussion_r1582147106 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java: ## @@ -1105,18 +1103,15 @@ private void

Re: [PR] Fix the -tf args description in ExportData [iotdb]

2024-04-28 Thread via GitHub
CloudWise-Lukemiao merged PR #12436: URL: https://github.com/apache/iotdb/pull/12436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-28 Thread via GitHub
sonarcloud[bot] commented on PR #12271: URL: https://github.com/apache/iotdb/pull/12271#issuecomment-2081497688 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Log InsertRowsNode in WAL [iotdb]

2024-04-28 Thread via GitHub
OneSizeFitsQuorum merged PR #12271: URL: https://github.com/apache/iotdb/pull/12271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-28 Thread via GitHub
sonarcloud[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2081816116 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-28 Thread via GitHub
codecov[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2081843283 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12441?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-28 Thread via GitHub
sonarcloud[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2081922723 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Normalize LoadCache interfaces [iotdb]

2024-04-28 Thread via GitHub
sonarcloud[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2081872926 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate