[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #449: Tooling for release
jixuan1989 opened a new pull request #449: Tooling for release URL: https://github.com/apache/incubator-iotdb/pull/449 just merging LeiRui's modification. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 merged pull request #441: fix release tools
jixuan1989 merged pull request #441: fix release tools URL: https://github.com/apache/incubator-iotdb/pull/441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar
jixuan1989 commented on a change in pull request #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar URL: https://github.com/apache/incubator-iotdb/pull/447#discussion_r334327377 ## File path: .gitignore ## @@ -79,7 +82,6 @@ grafana/data/ grafana/data/test.csv **/lib/ -*.jar Review comment: why you remove *.jar... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 merged pull request #448: Cherry pick from rel0.8
jixuan1989 merged pull request #448: Cherry pick from rel0.8 URL: https://github.com/apache/incubator-iotdb/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause
jt2594838 commented on a change in pull request #443: [IOTDB-240] fix unknown
time series in where clause
URL: https://github.com/apache/incubator-iotdb/pull/443#discussion_r334327289
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/strategy/optimizer/ConcatPathOptimizer.java
##
@@ -343,7 +346,7 @@ private void removeStarsInPath(List paths,
List afterConcatAggrega
try {
List actualPaths =
executor.getAllPaths(paths.get(i).getFullPath());
if(actualPaths.isEmpty()){
- throw new LogicalOptimizeException("Path: \"" + paths.get(i) + "\"
not corresponding any known time series");
+ throw new LogicalOptimizeException("Path: \"" + paths.get(i) + "\"
doesn't corresponding to any known time series");
Review comment:
not "ing"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #417: [IOTDB-234] Refactor TsFile storage on HDFS
jt2594838 commented on issue #417: [IOTDB-234] Refactor TsFile storage on HDFS URL: https://github.com/apache/incubator-iotdb/pull/417#issuecomment-541502505 If you insist on this design, at least you should save the constructor. And this test will show you that this is still slower compared with a direct call to new(). [ReflectionTest.txt](https://github.com/apache/incubator-iotdb/files/3722994/ReflectionTest.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] Genius-pig edited a comment on issue #409: [IOTDB-165][TsFile] Delete a current version and add a number version and an exception.
Genius-pig edited a comment on issue #409: [IOTDB-165][TsFile] Delete a current version and add a number version and an exception. URL: https://github.com/apache/incubator-iotdb/pull/409#issuecomment-541491965 > Hi, how about the new progress of this PR @jt2594838 He wanted me to delete some `position()` methods, do you have any suggestions?@jixuan1989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] Genius-pig commented on issue #409: [IOTDB-165][TsFile] Delete a current version and add a number version and an exception.
Genius-pig commented on issue #409: [IOTDB-165][TsFile] Delete a current version and add a number version and an exception. URL: https://github.com/apache/incubator-iotdb/pull/409#issuecomment-541491965 > Hi, how about the new progress of this PR @jt2594838 He wants me to delete some `position()` method, do you have any suggestions?@jixuan1989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #409: [IOTDB-165][TsFile] Delete a current version and add a number version and an exception.
jixuan1989 commented on issue #409: [IOTDB-165][TsFile] Delete a current version and add a number version and an exception. URL: https://github.com/apache/incubator-iotdb/pull/409#issuecomment-541491033 Hi, how about the new progress of this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #448: Cherry pick from rel0.8
jixuan1989 opened a new pull request #448: Cherry pick from rel0.8 URL: https://github.com/apache/incubator-iotdb/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
