[GitHub] [incubator-iotdb] qiaojialin merged pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
qiaojialin merged pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-22 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493240488 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing permissi

[GitHub] [incubator-iotdb] haimeiguo commented on a change in pull request #1693: [IOTDB-863]: add a switch to drop ouf-of-order data that is recognized by IoTDB

2020-09-22 Thread GitBox
haimeiguo commented on a change in pull request #1693: URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r493237697 ## File path: server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java ## @@ -26,6 +26,7 @@ import java.uti

[GitHub] [incubator-iotdb] qiaojialin closed pull request #1753: set props to null by default in createTimeseries to save memory

2020-09-22 Thread GitBox
qiaojialin closed pull request #1753: URL: https://github.com/apache/incubator-iotdb/pull/1753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-iotdb] qiaojialin commented on pull request #1753: set props to null by default in createTimeseries to save memory

2020-09-22 Thread GitBox
qiaojialin commented on pull request #1753: URL: https://github.com/apache/incubator-iotdb/pull/1753#issuecomment-697164838 Thanks Yuan! This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-22 Thread GitBox
jixuan1989 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493229430 ## File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java ## @@ -30,6 +30,7 @@ import org.apache.iotdb.db.

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-22 Thread GitBox
jixuan1989 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493178819 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing permis

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752#issuecomment-697118545 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1752&resolved=false&types=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752#issuecomment-697147122 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1752&resolved=false&types=BUG) [](http

[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1753: set props to null by default in createTimeseries to save memory

2020-09-22 Thread GitBox
qiaojialin opened a new pull request #1753: URL: https://github.com/apache/incubator-iotdb/pull/1753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-iotdb] qiaojialin commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB

2020-09-22 Thread GitBox
qiaojialin commented on pull request #1633: URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697138525 Hi, please recover the set memory in iotdb-env.bat This is an automated message from the Apache Git S

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1722: [IOTDB-872] Use system timezone in CLI

2020-09-22 Thread GitBox
qiaojialin merged pull request #1722: URL: https://github.com/apache/incubator-iotdb/pull/1722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-697115354 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1524&resolved=false&types=BUG) [](http

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
qiaojialin commented on a change in pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752#discussion_r493195177 ## File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertPlan.java ## @@ -70,12 +68,12 @@ public void setDataTypes(TSData

[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request #1731: [IOTDB-870] tags and attributes output

2020-09-22 Thread GitBox
liutaohua commented on a change in pull request #1731: URL: https://github.com/apache/incubator-iotdb/pull/1731#discussion_r492644306 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java ## @@ -937,12 +937,11 @@ public int getNodesCountInGivenLevel(Part

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752#issuecomment-697118545 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1752&resolved=false&types=BUG) [](http

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-09-22 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-694144147 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1524&resolved=false&types=BUG)

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
HTHou commented on a change in pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752#discussion_r493181498 ## File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertPlan.java ## @@ -70,12 +68,12 @@ public void setDataTypes(TSDataType[

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1748: Fix concurrency problem when auto register timeseries fix #1408

2020-09-22 Thread GitBox
qiaojialin merged pull request #1748: URL: https://github.com/apache/incubator-iotdb/pull/1748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
neuyilan commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492568246 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/schema/MeasurementSchema.java ## @@ -98,12 +98,11 @@ public static MeasurementS

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492563096 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/CompressionType.java ## @@ -52,6 +52,35 @@ public static Compre

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1642: In Session, the JDBC module can set the Boolean return data type to 0/1 or true/false.

2020-09-22 Thread GitBox
qiaojialin commented on a change in pull request #1642: URL: https://github.com/apache/incubator-iotdb/pull/1642#discussion_r492468763 ## File path: session/src/main/java/org/apache/iotdb/session/SessionDataSet.java ## @@ -93,7 +93,12 @@ private RowRecord constructRowRecordFrom

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1736: Cluster premerge

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-696472524 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

2020-09-22 Thread GitBox
mychaow commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r489981747 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -1002,48 +1004,57 @@ private void findNodes(MNode node, PartialPa

[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1693: [IOTDB-863]: add a switch to drop ouf-of-order data that is recognized by IoTDB

2020-09-22 Thread GitBox
SilverNarcissus commented on a change in pull request #1693: URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r492513870 ## File path: server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java ## @@ -26,6 +26,7 @@ import ja

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-696474324 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
mychaow commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492546747 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/CompressionType.java ## @@ -52,6 +52,35 @@ public static Compressi

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-09-22 Thread GitBox
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-690976244 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1748: Fix concurrency problem when auto register timeseries fix #1408

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #1748: URL: https://github.com/apache/incubator-iotdb/pull/1748#issuecomment-696475148 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1748&resolved=false&types=BUG) [](http

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1736: Cluster premerge

2020-09-22 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-695891439 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1747: fix ProgressBar bug

2020-09-22 Thread GitBox
qiaojialin merged pull request #1747: URL: https://github.com/apache/incubator-iotdb/pull/1747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
HTHou commented on a change in pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752#discussion_r493181498 ## File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertPlan.java ## @@ -70,12 +68,12 @@ public void setDataTypes(TSDataType[

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752#issuecomment-697118545 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1752&resolved=false&types=BUG) [](http

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-09-22 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-694144147 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1524&resolved=false&types=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-09-22 Thread GitBox
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-697115354 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1524&resolved=false&types=BUG) [](http

[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-22 Thread GitBox
qiaojialin opened a new pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752 In previous, the deviceMNode is cached in the InsertPlan. Actually we could cache the MeasurementMNode directly instead of the MeasurementSchema and deviceMNode.

[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request #1731: [IOTDB-870] tags and attributes output

2020-09-22 Thread GitBox
liutaohua commented on a change in pull request #1731: URL: https://github.com/apache/incubator-iotdb/pull/1731#discussion_r492644306 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java ## @@ -937,12 +937,11 @@ public int getNodesCountInGivenLevel(Part

[GitHub] [incubator-iotdb] Alima777 opened a new pull request #1751: [IOTDB-902] Order by time desc aggregation bug

2020-09-22 Thread GitBox
Alima777 opened a new pull request #1751: URL: https://github.com/apache/incubator-iotdb/pull/1751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492600924 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/schema/MeasurementSchema.java ## @@ -98,12 +98,11 @@ public static Measuremen

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492600695 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/TSEncoding.java ## @@ -51,6 +51,35 @@ public static TSEncoding

[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
neuyilan commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492568246 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/schema/MeasurementSchema.java ## @@ -98,12 +98,11 @@ public static MeasurementS

[GitHub] [incubator-iotdb] yhwangBonc commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
yhwangBonc commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492563096 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/CompressionType.java ## @@ -52,6 +52,35 @@ public static Compre

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-22 Thread GitBox
mychaow commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r492546747 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/enums/CompressionType.java ## @@ -52,6 +52,35 @@ public static Compressi

[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1693: [IOTDB-863]: add a switch to drop ouf-of-order data that is recognized by IoTDB

2020-09-22 Thread GitBox
SilverNarcissus commented on a change in pull request #1693: URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r492513870 ## File path: server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java ## @@ -26,6 +26,7 @@ import ja

[GitHub] [incubator-iotdb] MingzheLiu1998 opened a new pull request #1750: [Sonar] Fix Codesmell blocker and critical issue

2020-09-22 Thread GitBox
MingzheLiu1998 opened a new pull request #1750: URL: https://github.com/apache/incubator-iotdb/pull/1750 1. Rename variable 2. Define a constant name for repeated strings This is an automated message from the Apache Git Se