[GitHub] [incubator-iotdb] qiaojialin merged pull request #1756: [IOTDB-907] Change TreeSet to List in getAllDevices

2020-09-23 Thread GitBox
qiaojialin merged pull request #1756: URL: https://github.com/apache/incubator-iotdb/pull/1756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1736: Cluster premerge

2020-09-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-698106474 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1736: Cluster premerge

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-698118660 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1755: update the website because of graduation

2020-09-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1755: URL: https://github.com/apache/incubator-iotdb/pull/1755#issuecomment-698097449 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1755=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1755: update the website because of graduation

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1755: URL: https://github.com/apache/incubator-iotdb/pull/1755#issuecomment-698115480 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1755=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1736: Cluster premerge

2020-09-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-698078910 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1736: Cluster premerge

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-698106474 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1757: Improve the readUnLock way while inserting

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1757: URL: https://github.com/apache/incubator-iotdb/pull/1757#issuecomment-698100736 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1757=false=BUG)

[GitHub] [incubator-iotdb] zhanglingzhe0820 opened a new pull request #1758: add device chunk point cache

2020-09-23 Thread GitBox
zhanglingzhe0820 opened a new pull request #1758: URL: https://github.com/apache/incubator-iotdb/pull/1758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1755: update the website because of graduation

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1755: URL: https://github.com/apache/incubator-iotdb/pull/1755#issuecomment-698097449 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1755=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1756: [IOTDB-907] Change TreeSet to List in getAllDevices

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1756: URL: https://github.com/apache/incubator-iotdb/pull/1756#issuecomment-698096003 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1756=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-698092290 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

2020-09-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-696484714 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1757: Improve the readUnLock way while inserting

2020-09-23 Thread GitBox
qiaojialin opened a new pull request #1757: URL: https://github.com/apache/incubator-iotdb/pull/1757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-iotdb] yhwangBonc edited a comment on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB

2020-09-23 Thread GitBox
yhwangBonc edited a comment on pull request #1633: URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697349541 > Hi, I like the changes in `iotdb-env.bat`, good job! > > But let's consider the stop script... > > Suppose your IoTDB start-server script is at

[GitHub] [incubator-iotdb] samperson1997 opened a new pull request #1756: Change TreeSet to List in getAllDevices

2020-09-23 Thread GitBox
samperson1997 opened a new pull request #1756: URL: https://github.com/apache/incubator-iotdb/pull/1756 Change TreeSet to List in getAllDevices This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1736: Cluster premerge

2020-09-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-696482726 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1736: Cluster premerge

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1736: URL: https://github.com/apache/incubator-iotdb/pull/1736#issuecomment-698078910 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG)

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #1755: update the website because of graduation

2020-09-23 Thread GitBox
jixuan1989 opened a new pull request #1755: URL: https://github.com/apache/incubator-iotdb/pull/1755 the main change is removing "incubating" and disclaimer This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iotdb] yhwangBonc edited a comment on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB

2020-09-23 Thread GitBox
yhwangBonc edited a comment on pull request #1633: URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697349541 > Hi, I like the changes in `iotdb-env.bat`, good job! > > But let's consider the stop script... > > Suppose your IoTDB start-server script is at

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1578: Python SessionUT added

2020-09-23 Thread GitBox
HTHou commented on a change in pull request #1578: URL: https://github.com/apache/incubator-iotdb/pull/1578#discussion_r493989828 ## File path: importerCSV-py/src/utils/Field.py ## @@ -0,0 +1,158 @@ +from IoTDBConstants import TSDataType + + +class Field(object): Review

[GitHub] [incubator-iotdb] jixuan1989 merged pull request #1754: Update maven download url for TravisCI (WinOS)

2020-09-23 Thread GitBox
jixuan1989 merged pull request #1754: URL: https://github.com/apache/incubator-iotdb/pull/1754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1754: Update maven download url for TravisCI (WinOS)

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1754: URL: https://github.com/apache/incubator-iotdb/pull/1754#issuecomment-697378934 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1754=false=BUG)

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #1754: Update maven download url for TravisCI (WinOS)

2020-09-23 Thread GitBox
jixuan1989 opened a new pull request #1754: URL: https://github.com/apache/incubator-iotdb/pull/1754 The previous maven download link is invalid. So, update it to a new one. This is an automated message from the Apache Git

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1750: [Sonar] Fix Codesmell blocker and critical issue

2020-09-23 Thread GitBox
jixuan1989 commented on a change in pull request #1750: URL: https://github.com/apache/incubator-iotdb/pull/1750#discussion_r493558707 ## File path: server/src/main/java/org/apache/iotdb/db/cost/statistic/Measurement.java ## @@ -112,7 +112,7 @@ private long

[GitHub] [incubator-iotdb] yhwangBonc commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB

2020-09-23 Thread GitBox
yhwangBonc commented on pull request #1633: URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697349541 > Hi, I like the changes in `iotdb-env.bat`, good job! > > But let's consider the stop script... > > Suppose your IoTDB start-server script is at

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1750: [Sonar] Fix Codesmell blocker and critical issue

2020-09-23 Thread GitBox
jixuan1989 commented on a change in pull request #1750: URL: https://github.com/apache/incubator-iotdb/pull/1750#discussion_r493557741 ## File path: hive-connector/src/main/java/org/apache/iotdb/hive/TsFileDeserializer.java ## @@ -90,55 +91,55 @@ public Object

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB

2020-09-23 Thread GitBox
jixuan1989 commented on pull request #1633: URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697334567 Hi, I like the changes in `iotdb-env.bat`, good job! But let's consider the stop script... Suppose your IoTDB start-server script is at

[GitHub] [incubator-iotdb] yuqi1129 closed pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website

2020-09-23 Thread GitBox
yuqi1129 closed pull request #1737: URL: https://github.com/apache/incubator-iotdb/pull/1737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-iotdb] yuqi1129 commented on a change in pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website

2020-09-23 Thread GitBox
yuqi1129 commented on a change in pull request #1737: URL: https://github.com/apache/incubator-iotdb/pull/1737#discussion_r493510464 ## File path: hadoop/pom.xml ## @@ -85,26 +85,6 @@ - Review comment:

[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website

2020-09-23 Thread GitBox
yuqi1129 commented on pull request #1737: URL: https://github.com/apache/incubator-iotdb/pull/1737#issuecomment-697320607 This pull pull is mark as invalid, close it This is an automated message from the Apache Git Service.

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-23 Thread GitBox
jixuan1989 commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r493446488 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/utils/ReadWriteIOUtils.java ## @@ -82,6 +83,19 @@ public static boolean

[GitHub] [incubator-iotdb] yuqi1129 commented on a change in pull request #1737: [IOTDB-897] Remove duplicate maven plugin in module tsfile and website

2020-09-23 Thread GitBox
yuqi1129 commented on a change in pull request #1737: URL: https://github.com/apache/incubator-iotdb/pull/1737#discussion_r493341013 ## File path: site/pom.xml ## @@ -39,30 +39,6 @@ - Review comment: You are right, i mistake it

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1731: [IOTDB-870] tags and attributes output

2020-09-23 Thread GitBox
HTHou commented on a change in pull request #1731: URL: https://github.com/apache/incubator-iotdb/pull/1731#discussion_r493323543 ## File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConstant.java ## @@ -70,6 +70,8 @@ private IoTDBConstant() { public static

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1642: In Session, the JDBC module can set the Boolean return data type to 0/1 or true/false.

2020-09-23 Thread GitBox
HTHou commented on a change in pull request #1642: URL: https://github.com/apache/incubator-iotdb/pull/1642#discussion_r493304549 ## File path: example/jdbc/src/main/java/org/apache/iotdb/JDBCExample.java ## @@ -30,19 +30,19 @@ public class JDBCExample { public static void

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1642: In Session, the JDBC module can set the Boolean return data type to 0/1 or true/false.

2020-09-23 Thread GitBox
HTHou commented on a change in pull request #1642: URL: https://github.com/apache/incubator-iotdb/pull/1642#discussion_r493304549 ## File path: example/jdbc/src/main/java/org/apache/iotdb/JDBCExample.java ## @@ -30,19 +30,19 @@ public class JDBCExample { public static void

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493290903 ## File path: server/src/main/java/org/apache/iotdb/db/engine/flush/FlushManager.java ## @@ -93,6 +95,10 @@ public void runMayThrow() {

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-09-23 Thread GitBox
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-697205027 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-09-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-697115354 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [incubator-iotdb] liutaohua commented on pull request #1731: [IOTDB-870] tags and attributes output

2020-09-23 Thread GitBox
liutaohua commented on pull request #1731: URL: https://github.com/apache/incubator-iotdb/pull/1731#issuecomment-697197710 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1750: [Sonar] Fix Codesmell blocker and critical issue

2020-09-23 Thread GitBox
qiaojialin commented on a change in pull request #1750: URL: https://github.com/apache/incubator-iotdb/pull/1750#discussion_r493266292 ## File path: hive-connector/src/main/java/org/apache/iotdb/hive/TsFileDeserializer.java ## @@ -34,7 +34,8 @@ public class

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493261212 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493260857 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493260559 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493257238 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1750: [Sonar] Fix Codesmell blocker and critical issue

2020-09-23 Thread GitBox
qiaojialin commented on a change in pull request #1750: URL: https://github.com/apache/incubator-iotdb/pull/1750#discussion_r493256707 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/Decoder.java ## @@ -31,6 +31,9 @@ public abstract class

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493254937 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] yhwangBonc commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB

2020-09-23 Thread GitBox
yhwangBonc commented on pull request #1633: URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697182130 > Hi, please recover the set memory in iotdb-env.bat Ok,I annotated one and put it at the end

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493244986 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493244155 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1749: Avoid type conversion when encoding MeasureSchema

2020-09-23 Thread GitBox
HTHou commented on a change in pull request #1749: URL: https://github.com/apache/incubator-iotdb/pull/1749#discussion_r493242853 ## File path: tsfile/src/test/java/org/apache/iotdb/tsfile/write/writer/MeasurementSchemaSerializeTest.java ## @@ -0,0 +1,37 @@ +package

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1752: [IOTDB-904] fix update last cache NullPointerException

2020-09-23 Thread GitBox
qiaojialin merged pull request #1752: URL: https://github.com/apache/incubator-iotdb/pull/1752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
Alima777 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493240488 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing

[GitHub] [incubator-iotdb] qiaojialin closed pull request #1753: set props to null by default in createTimeseries to save memory

2020-09-23 Thread GitBox
qiaojialin closed pull request #1753: URL: https://github.com/apache/incubator-iotdb/pull/1753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] qiaojialin commented on pull request #1753: set props to null by default in createTimeseries to save memory

2020-09-23 Thread GitBox
qiaojialin commented on pull request #1753: URL: https://github.com/apache/incubator-iotdb/pull/1753#issuecomment-697164838 Thanks Yuan! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
jixuan1989 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493229430 ## File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java ## @@ -30,6 +30,7 @@ import

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1725: [IOTDB-23] Restart state monitor module

2020-09-23 Thread GitBox
jixuan1989 commented on a change in pull request #1725: URL: https://github.com/apache/incubator-iotdb/pull/1725#discussion_r493178819 ## File path: server/src/main/java/org/apache/iotdb/db/monitor/StatMonitor.java ## @@ -16,317 +16,291 @@ * specific language governing