[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1813: Try fixing website build error
sonarcloud[bot] removed a comment on pull request #1813: URL: https://github.com/apache/iotdb/pull/1813#issuecomment-706472972 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1813=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1813) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1813=duplicated_lines_density=list) No Duplication information The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1813: Try fixing website build error
sonarcloud[bot] commented on pull request #1813: URL: https://github.com/apache/iotdb/pull/1813#issuecomment-706484066 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1813=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1813) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1813=duplicated_lines_density=list) No Duplication information The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/iotdb/pull/460#issuecomment-706482515 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [48 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/iotdb/pull/460#issuecomment-704070188 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #1751: [IOTDB-902] Order by time desc aggregation bug
HTHou commented on pull request #1751: URL: https://github.com/apache/iotdb/pull/1751#issuecomment-706479244 There are some conflicts, please fix them... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1813: Try fixing website build error
sonarcloud[bot] commented on pull request #1813: URL: https://github.com/apache/iotdb/pull/1813#issuecomment-706472972 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1813=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1813=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1813) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1813=duplicated_lines_density=list) No Duplication information The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1736: Cluster premerge
sonarcloud[bot] commented on pull request #1736: URL: https://github.com/apache/iotdb/pull/1736#issuecomment-706472380 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1736: Cluster premerge
sonarcloud[bot] removed a comment on pull request #1736: URL: https://github.com/apache/iotdb/pull/1736#issuecomment-706467772 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] samperson1997 opened a new pull request #1813: Try fixing website build error
samperson1997 opened a new pull request #1813: URL: https://github.com/apache/iotdb/pull/1813 Try to fix website build error: ``` ERR! code ELIFECYCLE ERR! errno 3221225725 ERR! IoTDB@1.0.0 build: `node --max_old_space_size=8000 ./node_modules/vuepress/cli.js build src` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1736: Cluster premerge
sonarcloud[bot] removed a comment on pull request #1736: URL: https://github.com/apache/iotdb/pull/1736#issuecomment-703990941 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) [0.5% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1736: Cluster premerge
sonarcloud[bot] commented on pull request #1736: URL: https://github.com/apache/iotdb/pull/1736#issuecomment-706467772 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1736=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1736=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1736=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] samperson1997 opened a new pull request #1812: Updata MetadataIndexTree graph
samperson1997 opened a new pull request #1812: URL: https://github.com/apache/iotdb/pull/1812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1812: Update MetadataIndexTree graph
qiaojialin merged pull request #1812: URL: https://github.com/apache/iotdb/pull/1812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin closed pull request #1799: try to fix merge bug
qiaojialin closed pull request #1799: URL: https://github.com/apache/iotdb/pull/1799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1810: Print error log when set illegal storage group name
qiaojialin merged pull request #1810: URL: https://github.com/apache/iotdb/pull/1810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin closed pull request #1800: Try to fix bug
qiaojialin closed pull request #1800: URL: https://github.com/apache/iotdb/pull/1800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] commented on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-705998229 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1783: Remove unnecessary lock in MManager
sonarcloud[bot] commented on pull request #1783: URL: https://github.com/apache/iotdb/pull/1783#issuecomment-705341460 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1783=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1783) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1783=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1783=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1810: Print error log when set illegal storage group name
sonarcloud[bot] commented on pull request #1810: URL: https://github.com/apache/iotdb/pull/1810#issuecomment-705947313 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1810=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1810=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1810) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1810=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1810=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] mychaow commented on a change in pull request #1771: [IOTDB-884] batch create timeSeriesPlan
mychaow commented on a change in pull request #1771:
URL: https://github.com/apache/iotdb/pull/1771#discussion_r502177125
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##
@@ -98,26 +98,7 @@
import org.apache.iotdb.db.qp.physical.crud.QueryPlan;
import org.apache.iotdb.db.qp.physical.crud.RawDataQueryPlan;
import org.apache.iotdb.db.qp.physical.crud.UpdatePlan;
-import org.apache.iotdb.db.qp.physical.sys.AlterTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.AuthorPlan;
-import org.apache.iotdb.db.qp.physical.sys.CountPlan;
-import org.apache.iotdb.db.qp.physical.sys.CreateTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.DataAuthPlan;
-import org.apache.iotdb.db.qp.physical.sys.DeleteStorageGroupPlan;
-import org.apache.iotdb.db.qp.physical.sys.DeleteTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.FlushPlan;
-import org.apache.iotdb.db.qp.physical.sys.LoadConfigurationPlan;
-import org.apache.iotdb.db.qp.physical.sys.MergePlan;
-import org.apache.iotdb.db.qp.physical.sys.OperateFilePlan;
-import org.apache.iotdb.db.qp.physical.sys.SetStorageGroupPlan;
-import org.apache.iotdb.db.qp.physical.sys.SetTTLPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowChildPathsPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowDevicesPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowStorageGroupPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowTTLPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.TracingPlan;
+import org.apache.iotdb.db.qp.physical.sys.*;
Review comment:
thanks, I will fix it
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##
@@ -1040,6 +1029,29 @@ private boolean createTimeSeries(CreateTimeSeriesPlan
createTimeSeriesPlan)
return true;
}
+ private boolean createMultiTimeSeries(CreateMultiTimeSeriesPlan
createMultiTimeSeriesPlan) {
+Map results = new
HashMap<>(createMultiTimeSeriesPlan.getPaths().size());
+for (int i = 0; i < createMultiTimeSeriesPlan.getPaths().size(); i++) {
+ CreateTimeSeriesPlan plan = new
CreateTimeSeriesPlan(createMultiTimeSeriesPlan.getPaths().get(i),
+createMultiTimeSeriesPlan.getDataTypes().get(i),
createMultiTimeSeriesPlan.getEncodings().get(i),
+createMultiTimeSeriesPlan.getCompressors().get(i),
+createMultiTimeSeriesPlan.getProps() == null ? null :
createMultiTimeSeriesPlan.getProps().get(i),
+createMultiTimeSeriesPlan.getTags() == null ? null :
createMultiTimeSeriesPlan.getTags().get(i),
+createMultiTimeSeriesPlan.getAttributes() == null ? null :
createMultiTimeSeriesPlan.getAttributes().get(i),
+createMultiTimeSeriesPlan.getAlias() == null ? null :
createMultiTimeSeriesPlan.getAlias().get(i));
+
+ try {
+createTimeSeries(plan);
+ } catch (QueryProcessException e) {
+// do nothing
+results.put(createMultiTimeSeriesPlan.getIndexes().get(i), e);
+logger.debug("meet error while processing create timeseries. ", e);
Review comment:
yes, I will return error message to client
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] yuqi1129 commented on a change in pull request #1771: [IOTDB-884] batch create timeSeriesPlan
yuqi1129 commented on a change in pull request #1771:
URL: https://github.com/apache/iotdb/pull/1771#discussion_r502167271
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##
@@ -98,26 +98,7 @@
import org.apache.iotdb.db.qp.physical.crud.QueryPlan;
import org.apache.iotdb.db.qp.physical.crud.RawDataQueryPlan;
import org.apache.iotdb.db.qp.physical.crud.UpdatePlan;
-import org.apache.iotdb.db.qp.physical.sys.AlterTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.AuthorPlan;
-import org.apache.iotdb.db.qp.physical.sys.CountPlan;
-import org.apache.iotdb.db.qp.physical.sys.CreateTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.DataAuthPlan;
-import org.apache.iotdb.db.qp.physical.sys.DeleteStorageGroupPlan;
-import org.apache.iotdb.db.qp.physical.sys.DeleteTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.FlushPlan;
-import org.apache.iotdb.db.qp.physical.sys.LoadConfigurationPlan;
-import org.apache.iotdb.db.qp.physical.sys.MergePlan;
-import org.apache.iotdb.db.qp.physical.sys.OperateFilePlan;
-import org.apache.iotdb.db.qp.physical.sys.SetStorageGroupPlan;
-import org.apache.iotdb.db.qp.physical.sys.SetTTLPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowChildPathsPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowDevicesPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowStorageGroupPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowTTLPlan;
-import org.apache.iotdb.db.qp.physical.sys.ShowTimeSeriesPlan;
-import org.apache.iotdb.db.qp.physical.sys.TracingPlan;
+import org.apache.iotdb.db.qp.physical.sys.*;
Review comment:
It's not recommended to use star syntax in import
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##
@@ -1040,6 +1029,29 @@ private boolean createTimeSeries(CreateTimeSeriesPlan
createTimeSeriesPlan)
return true;
}
+ private boolean createMultiTimeSeries(CreateMultiTimeSeriesPlan
createMultiTimeSeriesPlan) {
+Map results = new
HashMap<>(createMultiTimeSeriesPlan.getPaths().size());
+for (int i = 0; i < createMultiTimeSeriesPlan.getPaths().size(); i++) {
+ CreateTimeSeriesPlan plan = new
CreateTimeSeriesPlan(createMultiTimeSeriesPlan.getPaths().get(i),
+createMultiTimeSeriesPlan.getDataTypes().get(i),
createMultiTimeSeriesPlan.getEncodings().get(i),
+createMultiTimeSeriesPlan.getCompressors().get(i),
+createMultiTimeSeriesPlan.getProps() == null ? null :
createMultiTimeSeriesPlan.getProps().get(i),
+createMultiTimeSeriesPlan.getTags() == null ? null :
createMultiTimeSeriesPlan.getTags().get(i),
+createMultiTimeSeriesPlan.getAttributes() == null ? null :
createMultiTimeSeriesPlan.getAttributes().get(i),
+createMultiTimeSeriesPlan.getAlias() == null ? null :
createMultiTimeSeriesPlan.getAlias().get(i));
+
+ try {
+createTimeSeries(plan);
+ } catch (QueryProcessException e) {
+// do nothing
+results.put(createMultiTimeSeriesPlan.getIndexes().get(i), e);
+logger.debug("meet error while processing create timeseries. ", e);
Review comment:
Maybe we need a switch to allow partial success if error log was output
in debug level
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1795: [IOTDB-933] Fix antlr4 which caused benchmark throw exception
sonarcloud[bot] removed a comment on pull request #1795: URL: https://github.com/apache/iotdb/pull/1795#issuecomment-703422319 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1795=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1795) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1795=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1795=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou closed pull request #1809: Fix some website links
HTHou closed pull request #1809: URL: https://github.com/apache/iotdb/pull/1809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1783: Remove unnecessary lock in MManager
qiaojialin merged pull request #1783: URL: https://github.com/apache/iotdb/pull/1783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1811: Fix num of tsfiles statistics errors using Tracing
qiaojialin merged pull request #1811: URL: https://github.com/apache/iotdb/pull/1811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Genius-pig commented on pull request #1795: [IOTDB-933] Fix antlr4 which caused benchmark throw exception
Genius-pig commented on pull request #1795: URL: https://github.com/apache/iotdb/pull/1795#issuecomment-705435803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1808: [IOTDB-936] Refactor getAllDevices in TsFileSequenceReader
qiaojialin merged pull request #1808: URL: https://github.com/apache/iotdb/pull/1808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1783: Remove unnecessary lock in MManager
sonarcloud[bot] removed a comment on pull request #1783: URL: https://github.com/apache/iotdb/pull/1783#issuecomment-704789527 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1783=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1783=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1783) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1783=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1783=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] removed a comment on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-704839842 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] jt2594838 commented on a change in pull request #1736: Cluster premerge
jt2594838 commented on a change in pull request #1736:
URL: https://github.com/apache/iotdb/pull/1736#discussion_r502167412
##
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##
@@ -63,16 +63,17 @@ force_wal_period_in_ms=100
### Directory Configuration
-# system dir
-# If this property is unset, system will save the data in the default relative
path directory under the IoTDB folder(i.e., %IOTDB_HOME%/data/system).
+# base dir
+# If this property is unset, system will save the data in the default relative
path directory under the IoTDB folder(i.e., %IOTDB_HOME%/data).
# If it is absolute, system will save the data in exact location it points to.
# If it is relative, system will save the data in the relative path directory
it indicates under the IoTDB folder.
+# Note: If sys_dir is assigned an empty string(i.e.,zero-size), it will be
handled as a relative path.
# For windows platform
# If its prefix is a drive specifier followed by "\\", or if its prefix is
"", then the path is absolute. Otherwise, it is relative.
-# system_dir=data\\system
+# base_dir=data
Review comment:
done
##
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##
@@ -381,39 +385,57 @@ public void syncCloseAllProcessor() {
}
public void forceCloseAllProcessor() throws TsFileProcessorException {
-logger.info("Start closing all storage group processor");
+logger.info("Start force closing all storage group processor");
for (StorageGroupProcessor processor : processorMap.values()) {
processor.forceCloseAllWorkingTsFileProcessors();
}
}
- public void asyncCloseProcessor(PartialPath storageGroupPath, boolean isSeq)
{
+ public void closeProcessor(PartialPath storageGroupPath, boolean isSeq,
boolean isSync) {
StorageGroupProcessor processor = processorMap.get(storageGroupPath);
-if (processor != null) {
- logger.info("async closing sg processor is called for closing {}, seq =
{}", storageGroupPath,
- isSeq);
- processor.writeLock();
- try {
-if (isSeq) {
- // to avoid concurrent modification problem, we need a new array list
- for (TsFileProcessor tsfileProcessor : new ArrayList<>(
- processor.getWorkSequenceTsFileProcessors())) {
+if (processor == null) {
+ return;
+}
+
+logger.info("async closing sg processor is called for closing {}, seq =
{}", storageGroupPath,
Review comment:
fixed
##
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##
@@ -381,39 +385,57 @@ public void syncCloseAllProcessor() {
}
public void forceCloseAllProcessor() throws TsFileProcessorException {
-logger.info("Start closing all storage group processor");
+logger.info("Start force closing all storage group processor");
for (StorageGroupProcessor processor : processorMap.values()) {
processor.forceCloseAllWorkingTsFileProcessors();
}
}
- public void asyncCloseProcessor(PartialPath storageGroupPath, boolean isSeq)
{
+ public void closeProcessor(PartialPath storageGroupPath, boolean isSeq,
boolean isSync) {
Review comment:
fixed
##
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##
@@ -381,39 +385,57 @@ public void syncCloseAllProcessor() {
}
public void forceCloseAllProcessor() throws TsFileProcessorException {
-logger.info("Start closing all storage group processor");
+logger.info("Start force closing all storage group processor");
for (StorageGroupProcessor processor : processorMap.values()) {
processor.forceCloseAllWorkingTsFileProcessors();
}
}
- public void asyncCloseProcessor(PartialPath storageGroupPath, boolean isSeq)
{
+ public void closeProcessor(PartialPath storageGroupPath, boolean isSeq,
boolean isSync) {
StorageGroupProcessor processor = processorMap.get(storageGroupPath);
-if (processor != null) {
- logger.info("async closing sg processor is called for closing {}, seq =
{}", storageGroupPath,
- isSeq);
- processor.writeLock();
- try {
-if (isSeq) {
- // to avoid concurrent modification problem, we need a new array list
- for (TsFileProcessor tsfileProcessor : new ArrayList<>(
- processor.getWorkSequenceTsFileProcessors())) {
+if (processor == null) {
+ return;
+}
+
+logger.info("async closing sg processor is called for closing {}, seq =
{}", storageGroupPath,
+isSeq);
+processor.writeLock();
+try {
+ if (isSeq) {
+// to avoid concurrent modification problem, we need a new array list
+for (TsFileProcessor tsfileProcessor : new ArrayList<>(
+processor.getWorkSequenceTsFileProcessors())) {
+ if (isSync) {
+processor.syncCloseOneTsFileProcessor(true,
[GitHub] [iotdb] yuqi1129 commented on a change in pull request #1785: [IOTDB-928] Make ENCODING optional in create time series sentence
yuqi1129 commented on a change in pull request #1785:
URL: https://github.com/apache/iotdb/pull/1785#discussion_r502131992
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
##
@@ -1169,9 +1170,15 @@ private PartialPath parseFullPath(FullPathContext ctx) {
public void enterAttributeClauses(AttributeClausesContext ctx) {
super.enterAttributeClauses(ctx);
String dataType = ctx.dataType().getChild(0).getText().toUpperCase();
-String encoding = ctx.encoding().getChild(0).getText().toUpperCase();
createTimeSeriesOperator.setDataType(TSDataType.valueOf(dataType));
-createTimeSeriesOperator.setEncoding(TSEncoding.valueOf(encoding));
+
+TSEncoding encoding = TSEncoding.PLAIN;
Review comment:
OK, I will assign a default value according to the data type
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] samperson1997 commented on a change in pull request #1808: [IOTDB-936] Refactor getAllDevices in TsFileSequenceReader
samperson1997 commented on a change in pull request #1808:
URL: https://github.com/apache/iotdb/pull/1808#discussion_r501679277
##
File path:
tsfile/src/test/java/org/apache/iotdb/tsfile/read/GetAllDevicesTest.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.tsfile.read;
+
+import java.io.IOException;
+import java.util.List;
+import org.apache.iotdb.tsfile.common.conf.TSFileConfig;
+import org.apache.iotdb.tsfile.common.conf.TSFileDescriptor;
+import org.apache.iotdb.tsfile.utils.FileGenerator;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+public class GetAllDevicesTest {
+
+ private final TSFileConfig conf = TSFileDescriptor.getInstance().getConfig();
+ private int maxDegreeOfIndexNode;
+ private static final String FILE_PATH = FileGenerator.outputDataFile;
+
+ @Before
+ public void before() {
+maxDegreeOfIndexNode = conf.getMaxDegreeOfIndexNode();
+conf.setMaxDegreeOfIndexNode(3);
+ }
+
+ @After
+ public void after() throws IOException {
+FileGenerator.after();
+conf.setMaxDegreeOfIndexNode(maxDegreeOfIndexNode);
+ }
+
+ @Test
+ public void testGetAllDevices1() throws IOException {
+testGetAllDevices(2, 2);
+ }
+
+ @Test
+ public void testGetAllDevices2() throws IOException {
+testGetAllDevices(2, 50);
+ }
+
+ @Test
+ public void testGetAllDevices3() throws IOException {
+testGetAllDevices(50, 2);
+ }
+
+ @Test
+ public void testGetAllDevices4() throws IOException {
+testGetAllDevices(50, 50);
+ }
+
+ public void testGetAllDevices(int deviceNum, int measurementNum) throws
IOException {
+FileGenerator.generateFile(1, deviceNum, measurementNum);
+TsFileSequenceReader fileReader = new TsFileSequenceReader(FILE_PATH);
+ReadOnlyTsFile tsFile = new ReadOnlyTsFile(fileReader);
+
+// test
+TsFileSequenceReader reader = new TsFileSequenceReader(FILE_PATH);
Review comment:
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1808: [IOTDB-936] Refactor getAllDevices in TsFileSequenceReader
sonarcloud[bot] commented on pull request #1808: URL: https://github.com/apache/iotdb/pull/1808#issuecomment-705326071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #1736: Cluster premerge
qiaojialin commented on a change in pull request #1736:
URL: https://github.com/apache/iotdb/pull/1736#discussion_r500718885
##
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##
@@ -63,16 +63,17 @@ force_wal_period_in_ms=100
### Directory Configuration
-# system dir
-# If this property is unset, system will save the data in the default relative
path directory under the IoTDB folder(i.e., %IOTDB_HOME%/data/system).
+# base dir
+# If this property is unset, system will save the data in the default relative
path directory under the IoTDB folder(i.e., %IOTDB_HOME%/data).
# If it is absolute, system will save the data in exact location it points to.
# If it is relative, system will save the data in the relative path directory
it indicates under the IoTDB folder.
+# Note: If sys_dir is assigned an empty string(i.e.,zero-size), it will be
handled as a relative path.
# For windows platform
# If its prefix is a drive specifier followed by "\\", or if its prefix is
"", then the path is absolute. Otherwise, it is relative.
-# system_dir=data\\system
+# base_dir=data
Review comment:
recover this
##
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##
@@ -381,39 +385,57 @@ public void syncCloseAllProcessor() {
}
public void forceCloseAllProcessor() throws TsFileProcessorException {
-logger.info("Start closing all storage group processor");
+logger.info("Start force closing all storage group processor");
for (StorageGroupProcessor processor : processorMap.values()) {
processor.forceCloseAllWorkingTsFileProcessors();
}
}
- public void asyncCloseProcessor(PartialPath storageGroupPath, boolean isSeq)
{
+ public void closeProcessor(PartialPath storageGroupPath, boolean isSeq,
boolean isSync) {
Review comment:
```suggestion
public void closeStorageGroupProcessor(PartialPath storageGroupPath,
boolean isSeq, boolean isSync) {
```
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/mnode/MNode.java
##
@@ -85,7 +87,7 @@ public boolean hasChild(String name) {
*/
public void addChild(String name, MNode child) {
if (children == null) {
- children = new LinkedHashMap<>();
+ children = new ConcurrentSkipListMap<>();
Review comment:
wait for Kaifeng's PR
##
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##
@@ -381,39 +385,57 @@ public void syncCloseAllProcessor() {
}
public void forceCloseAllProcessor() throws TsFileProcessorException {
-logger.info("Start closing all storage group processor");
+logger.info("Start force closing all storage group processor");
for (StorageGroupProcessor processor : processorMap.values()) {
processor.forceCloseAllWorkingTsFileProcessors();
}
}
- public void asyncCloseProcessor(PartialPath storageGroupPath, boolean isSeq)
{
+ public void closeProcessor(PartialPath storageGroupPath, boolean isSeq,
boolean isSync) {
StorageGroupProcessor processor = processorMap.get(storageGroupPath);
-if (processor != null) {
- logger.info("async closing sg processor is called for closing {}, seq =
{}", storageGroupPath,
- isSeq);
- processor.writeLock();
- try {
-if (isSeq) {
- // to avoid concurrent modification problem, we need a new array list
- for (TsFileProcessor tsfileProcessor : new ArrayList<>(
- processor.getWorkSequenceTsFileProcessors())) {
+if (processor == null) {
+ return;
+}
+
+logger.info("async closing sg processor is called for closing {}, seq =
{}", storageGroupPath,
Review comment:
async should be inferred from parameter
##
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##
@@ -381,39 +385,57 @@ public void syncCloseAllProcessor() {
}
public void forceCloseAllProcessor() throws TsFileProcessorException {
-logger.info("Start closing all storage group processor");
+logger.info("Start force closing all storage group processor");
for (StorageGroupProcessor processor : processorMap.values()) {
processor.forceCloseAllWorkingTsFileProcessors();
}
}
- public void asyncCloseProcessor(PartialPath storageGroupPath, boolean isSeq)
{
+ public void closeProcessor(PartialPath storageGroupPath, boolean isSeq,
boolean isSync) {
StorageGroupProcessor processor = processorMap.get(storageGroupPath);
-if (processor != null) {
- logger.info("async closing sg processor is called for closing {}, seq =
{}", storageGroupPath,
- isSeq);
- processor.writeLock();
- try {
-if (isSeq) {
- // to avoid concurrent modification problem, we need a new array list
- for (TsFileProcessor tsfileProcessor : new ArrayList<>(
-
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1809: Fix some website links
sonarcloud[bot] commented on pull request #1809: URL: https://github.com/apache/iotdb/pull/1809#issuecomment-705329713 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1809=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1809=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1809) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1809=duplicated_lines_density=list) No Duplication information The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Ring-k commented on pull request #1795: [IOTDB-933] Fix antlr4 which caused benchmark throw exception
Ring-k commented on pull request #1795: URL: https://github.com/apache/iotdb/pull/1795#issuecomment-705589137 So, before this pull request, the system will cause exception in benchmark, but after your improvement the exception won't occur, right? In this case, there must be some difference between these two implementations. Pls find out the difference. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1795: [IOTDB-933] Fix antlr4 which caused benchmark throw exception
sonarcloud[bot] commented on pull request #1795: URL: https://github.com/apache/iotdb/pull/1795#issuecomment-705924791 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1795=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1795=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1795) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1795=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1795=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1808: [IOTDB-936] Refactor getAllDevices in TsFileSequenceReader
HTHou commented on a change in pull request #1808:
URL: https://github.com/apache/iotdb/pull/1808#discussion_r501515042
##
File path:
tsfile/src/test/java/org/apache/iotdb/tsfile/read/GetAllDevicesTest.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.tsfile.read;
+
+import java.io.IOException;
+import java.util.List;
+import org.apache.iotdb.tsfile.common.conf.TSFileConfig;
+import org.apache.iotdb.tsfile.common.conf.TSFileDescriptor;
+import org.apache.iotdb.tsfile.utils.FileGenerator;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+public class GetAllDevicesTest {
+
+ private final TSFileConfig conf = TSFileDescriptor.getInstance().getConfig();
+ private int maxDegreeOfIndexNode;
+ private static final String FILE_PATH = FileGenerator.outputDataFile;
+
+ @Before
+ public void before() {
+maxDegreeOfIndexNode = conf.getMaxDegreeOfIndexNode();
+conf.setMaxDegreeOfIndexNode(3);
+ }
+
+ @After
+ public void after() throws IOException {
+FileGenerator.after();
+conf.setMaxDegreeOfIndexNode(maxDegreeOfIndexNode);
+ }
+
+ @Test
+ public void testGetAllDevices1() throws IOException {
+testGetAllDevices(2, 2);
+ }
+
+ @Test
+ public void testGetAllDevices2() throws IOException {
+testGetAllDevices(2, 50);
+ }
+
+ @Test
+ public void testGetAllDevices3() throws IOException {
+testGetAllDevices(50, 2);
+ }
+
+ @Test
+ public void testGetAllDevices4() throws IOException {
+testGetAllDevices(50, 50);
+ }
+
+ public void testGetAllDevices(int deviceNum, int measurementNum) throws
IOException {
+FileGenerator.generateFile(1, deviceNum, measurementNum);
+TsFileSequenceReader fileReader = new TsFileSequenceReader(FILE_PATH);
+ReadOnlyTsFile tsFile = new ReadOnlyTsFile(fileReader);
+
+// test
+TsFileSequenceReader reader = new TsFileSequenceReader(FILE_PATH);
Review comment:
These two readers should be closed...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1808: [IOTDB-936] Refactor getAllDevices in TsFileSequenceReader
qiaojialin merged pull request #1808: URL: https://github.com/apache/iotdb/pull/1808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1811: Fix num of tsfiles statistics errors using Tracing
qiaojialin merged pull request #1811: URL: https://github.com/apache/iotdb/pull/1811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] commented on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-705998229 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1716: Restful API v2 (using netty)
sonarcloud[bot] removed a comment on pull request #1716: URL: https://github.com/apache/iotdb/pull/1716#issuecomment-704839842 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/i ssues?id=apache_incubator-iotdb=1716=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1716=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1716=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] mychaow commented on a change in pull request #1771: [IOTDB-884] batch create timeSeriesPlan
mychaow commented on a change in pull request #1771:
URL: https://github.com/apache/iotdb/pull/1771#discussion_r502208456
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##
@@ -1040,6 +1029,29 @@ private boolean createTimeSeries(CreateTimeSeriesPlan
createTimeSeriesPlan)
return true;
}
+ private boolean createMultiTimeSeries(CreateMultiTimeSeriesPlan
createMultiTimeSeriesPlan) {
+Map results = new
HashMap<>(createMultiTimeSeriesPlan.getPaths().size());
+for (int i = 0; i < createMultiTimeSeriesPlan.getPaths().size(); i++) {
+ CreateTimeSeriesPlan plan = new
CreateTimeSeriesPlan(createMultiTimeSeriesPlan.getPaths().get(i),
+createMultiTimeSeriesPlan.getDataTypes().get(i),
createMultiTimeSeriesPlan.getEncodings().get(i),
+createMultiTimeSeriesPlan.getCompressors().get(i),
+createMultiTimeSeriesPlan.getProps() == null ? null :
createMultiTimeSeriesPlan.getProps().get(i),
+createMultiTimeSeriesPlan.getTags() == null ? null :
createMultiTimeSeriesPlan.getTags().get(i),
+createMultiTimeSeriesPlan.getAttributes() == null ? null :
createMultiTimeSeriesPlan.getAttributes().get(i),
+createMultiTimeSeriesPlan.getAlias() == null ? null :
createMultiTimeSeriesPlan.getAlias().get(i));
+
+ try {
+createTimeSeries(plan);
+ } catch (QueryProcessException e) {
+// do nothing
+results.put(createMultiTimeSeriesPlan.getIndexes().get(i), e);
+logger.debug("meet error while processing create timeseries. ", e);
Review comment:
yes, I will return error message to client
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
